From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by sourceware.org (Postfix) with ESMTPS id D5D903857431; Wed, 4 May 2022 06:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5D903857431 Received: by mail-vs1-xe2a.google.com with SMTP id m62so292824vsc.2; Tue, 03 May 2022 23:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kglKjaa9CrKnbrAGAK6CMtsNKWM+ERkXXpa4agv6REQ=; b=dk79GPM581Gb139kunBfuylf2To+A0ctUbh0ienAyKfYhltuZr/G986rvfGDptD4nz OC96FkiTFr2+emPzQ74V0IzknvClbM8oUpbwMDGhJ25bMTJwCnNJqaliPBUqdqE5q13f FobdI0NMYvUtMSYRZdn6uYomjrPIpCypxZb38LbrVt1yoDrLLQZ9WSyrzR3EO47KbL17 l/ZdlWgIiieflQrOMB3wu/o24uhMgH9TuLdBsxVKZH8X1eY237o9OyGxahE2pq+mxzQ0 /2ILtAiu0WT8e9gdwFGSrW4GHbRJ/fd/CZSS5pNZasdMrenvfzRbrG6bks808OqDVnGj RkTg== X-Gm-Message-State: AOAM532crswIjFXYGt+biUQLZIJp6qhSLMrMJmMCkrkQaPGl+OBkGO84 GdDRiZzcGS2KRcxOsAkvUORM52x/XeM7Gdwlqbw= X-Google-Smtp-Source: ABdhPJz0Kx9h9zlVYu/JPy96D150XuyJ7xS48JzF7N70Bkahxusd+PrEeR9mPX6k2W2UODkqsTvaDW6FgbEXrtz8wik= X-Received: by 2002:a05:6102:e0f:b0:32c:c002:3ca3 with SMTP id o15-20020a0561020e0f00b0032cc0023ca3mr5793892vst.28.1651644105248; Tue, 03 May 2022 23:01:45 -0700 (PDT) MIME-Version: 1.0 References: <20220212102529.1380928-1-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Tue, 3 May 2022 23:01:09 -0700 Message-ID: Subject: Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms To: Noah Goldstein , Libc-stable Mailing List Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 06:01:47 -0000 On Sat, Feb 12, 2022 at 1:44 PM Noah Goldstein via Libc-alpha wrote: > > On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu wrote: > > > > On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein wrote: > > > > > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 > > > Author: H.J. Lu > > > Date: Mon Feb 7 05:55:15 2022 -0800 > > > > > > x86-64: Optimize bzero > > > > > > Remove setting the .text section for the code. This commit > > > adds that back. > > > --- > > > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > index 7c94fcdae1..785fee1d57 100644 > > > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > @@ -114,6 +114,7 @@ > > > # error SECTION is not defined! > > > #endif > > > > > > + .section SECTION(.text), "ax", @progbits > > > #if IS_IN (libc) > > > # if defined SHARED > > > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned)) > > > -- > > > 2.25.1 > > > > > > > LGTM. > > > > Reviewed-by: H.J. Lu > > > > Thanks. > > > > Thanks pushed. > > -- > > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil