From: Sunil Pandey <skpgkp2@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>, libc-stable@sourceware.org
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1 2/3] x86: Modify ENTRY in sysdep.h so that p2align can be specified
Date: Fri, 22 Apr 2022 18:13:24 -0700 [thread overview]
Message-ID: <CAMAf5_fO-kub+DQfv6_M3u+2GyVgLfZdUHRUNbXtdUxN92ad=A@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfKidMCHU9MJLGpzXL-CXmXhR43B4dfnEESDfaMruW2zkg@mail.gmail.com>
On Fri, Oct 8, 2021 at 10:20 AM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Fri, Oct 8, 2021 at 9:27 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> > On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein <goldstein.w.n@gmail.com>
> > wrote:
> > >
> > > No bug.
> > >
> > > This change adds a new macro ENTRY_P2ALIGN which takes a second
> > > argument, log2 of the desired function alignment.
> > >
> > > The old ENTRY(name) macro is just ENTRY_P2ALIGN(name, 4) so this
> > > doesn't affect any existing functionality.
> > >
> > > Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
> > > ---
> > > Note this is a duplicate of:
> > > [v2,1/2] x86: Modify ENTRY in sysdep.h so that p2align can be specified
> > >
> > https://patchwork.sourceware.org/project/glibc/patch/20210922051657.1655745-1-goldstein.w.n@gmail.com/
> > >
> > > sysdeps/x86/sysdep.h | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h
> > > index cac1d762fb..937180c1bd 100644
> > > --- a/sysdeps/x86/sysdep.h
> > > +++ b/sysdeps/x86/sysdep.h
> > > @@ -78,15 +78,18 @@ enum cf_protection_level
> > > #define ASM_SIZE_DIRECTIVE(name) .size name,.-name;
> > >
> > > /* Define an entry point visible from C. */
> > > -#define ENTRY(name)
> > \
> > > +#define ENTRY_P2ALIGN(name, alignment)
> > \
> > > .globl C_SYMBOL_NAME(name);
> > \
> > > .type C_SYMBOL_NAME(name),@function;
> > \
> > > - .align ALIGNARG(4);
> > \
> > > + .align ALIGNARG(alignment);
> > \
> > > C_LABEL(name)
> > \
> > > cfi_startproc;
> > \
> > > _CET_ENDBR;
> > \
> > > CALL_MCOUNT
> > >
> > > +/* Common entry 16 byte aligns. */
> > > +#define ENTRY(name) ENTRY_P2ALIGN (name, 4)
> > > +
> > > #undef END
> > > #define END(name)
> > \
> > > cfi_endproc;
> > \
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> > Thanks.
> >
>
> Thanks. Pushed.
>
>
> >
> > --
> > H.J.
> >
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
next parent reply other threads:[~2022-04-23 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210926205306.900081-1-goldstein.w.n@gmail.com>
[not found] ` <20210926205306.900081-2-goldstein.w.n@gmail.com>
[not found] ` <CAMe9rOqaYwc=TujPmZ+KEicKBEUachMdXg5ixKjKxcgBYN=h0w@mail.gmail.com>
[not found] ` <CAFUsyfKidMCHU9MJLGpzXL-CXmXhR43B4dfnEESDfaMruW2zkg@mail.gmail.com>
2022-04-23 1:13 ` Sunil Pandey [this message]
[not found] ` <20210926205306.900081-3-goldstein.w.n@gmail.com>
[not found] ` <CAMe9rOo-qJRkqYjwuO_pqQySfDFHtg6wSTcM1W=APwCCFpPiWg@mail.gmail.com>
[not found] ` <CAFUsyfKhtVfqbpbs-S2b2XjfOh9rDh58wpUuy4+oYgPx1Ecbhw@mail.gmail.com>
2022-04-23 1:19 ` [PATCH v1 3/3] x86: Optimize memset-vec-unaligned-erms.S Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_fO-kub+DQfv6_M3u+2GyVgLfZdUHRUNbXtdUxN92ad=A@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).