From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by sourceware.org (Postfix) with ESMTPS id 20E793884568; Thu, 12 May 2022 19:42:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20E793884568 Received: by mail-vs1-xe2a.google.com with SMTP id w124so6287978vsb.8; Thu, 12 May 2022 12:42:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hR88AZH852vInP1GWTaumBOb/w8Ts2wZEnQZIKrutcE=; b=PY0lPSRPNeYvUggWEgVmA3/MSBc10f3Izi/HiWqDjDyyNbLHlsGZKRd14VAD6cCnjS ZEDDoGRzqr/fhaqFUdnRAlGK2yv6WMh6e+N96y/rppXzZZy0r6w1gpqOUdSiWoTR+Wml uS1LmdQvCYMAUjEDsKTJmJq/aJpIW9i0uKTCvqZEU56gpmU9kd/sHTrLqCZ+Zhjrxdmp K4Wj6mEFCF+9ofIsWosbJ3FESv2evzVejboTPy6C3A/5viDQoVZy0WBws7RPkUJVAdDw JBHtuqXEQv1bjSJuNr2VaxVtdk2oPRK85+fgaokAm/6lts0DudbbGDKnzipSI3fdf/eO ijVw== X-Gm-Message-State: AOAM533NPrq9Q5G9CAWBtbWNGHQbRKF8CgPQz6OBzUZqSHQ6rN7Qosft Bl6g/7LTesjmJRBKjIxhFlV4a1Qea/JZwegqGh0zdgXGup8= X-Google-Smtp-Source: ABdhPJxV+Xghv3ev4VzZdqZEEK7eFEeRIs5VODCKiIEh5F4J+n3nu0rgDCoTMv2oHiB6lkJETEBp2ZGTZoarkhw/kps= X-Received: by 2002:a67:ef0a:0:b0:32d:4bb9:23f with SMTP id j10-20020a67ef0a000000b0032d4bb9023fmr962904vsr.47.1652384543463; Thu, 12 May 2022 12:42:23 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-10-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Thu, 12 May 2022 12:41:47 -0700 Message-ID: Subject: Re: [PATCH v1 10/23] x86: Remove strpbrk-sse2.S and use the generic implementation To: "H.J. Lu" , Libc-stable Mailing List Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 19:42:25 -0000 On Thu, Mar 24, 2022 at 12:00 PM H.J. Lu via Libc-alpha wrote: > > On Wed, Mar 23, 2022 at 3:00 PM Noah Goldstein wrote: > > > > The generic implementation is faster (see strcspn commit). > > > > All string/memory tests pass. > > --- > > .../x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} | 9 ++++----- > > sysdeps/x86_64/strpbrk.S | 3 --- > > 2 files changed, 4 insertions(+), 8 deletions(-) > > rename sysdeps/x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} (84%) > > delete mode 100644 sysdeps/x86_64/strpbrk.S > > > > diff --git a/sysdeps/x86_64/multiarch/strpbrk-sse2.S b/sysdeps/x86_64/multiarch/strpbrk-sse2.c > > similarity index 84% > > rename from sysdeps/x86_64/multiarch/strpbrk-sse2.S > > rename to sysdeps/x86_64/multiarch/strpbrk-sse2.c > > index d537b6c27b..d03214c4fb 100644 > > --- a/sysdeps/x86_64/multiarch/strpbrk-sse2.S > > +++ b/sysdeps/x86_64/multiarch/strpbrk-sse2.c > > @@ -1,4 +1,4 @@ > > -/* strpbrk optimized with SSE2. > > +/* strpbrk. > > Copyright (C) 2017-2022 Free Software Foundation, Inc. > > This file is part of the GNU C Library. > > > > @@ -19,11 +19,10 @@ > > #if IS_IN (libc) > > > > # include > > -# define strcspn __strpbrk_sse2 > > +# define STRPBRK __strpbrk_sse2 > > > > # undef libc_hidden_builtin_def > > -# define libc_hidden_builtin_def(strpbrk) > > +# define libc_hidden_builtin_def(STRPBRK) > > #endif > > > > -#define USE_AS_STRPBRK > > -#include > > +#include > > diff --git a/sysdeps/x86_64/strpbrk.S b/sysdeps/x86_64/strpbrk.S > > deleted file mode 100644 > > index 21888a5b92..0000000000 > > --- a/sysdeps/x86_64/strpbrk.S > > +++ /dev/null > > @@ -1,3 +0,0 @@ > > -#define strcspn strpbrk > > -#define USE_AS_STRPBRK > > -#include > > -- > > 2.25.1 > > > > LGTM. > > Reviewed-by: H.J. Lu > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil