public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
* Re: PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203]
       [not found]                             ` <CAMe9rOpK-d_0u08j7b5PecErpM+FDxK0cSYXwxG776RMXB8o0Q@mail.gmail.com>
@ 2022-05-02 13:59                               ` Sunil Pandey
  2022-05-03 18:51                                 ` Sunil Pandey
  0 siblings, 1 reply; 2+ messages in thread
From: Sunil Pandey @ 2022-05-02 13:59 UTC (permalink / raw)
  To: H.J. Lu, Libc-stable Mailing List; +Cc: Florian Weimer, H.J. Lu via Libc-alpha

On Thu, Oct 15, 2020 at 5:54 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Thu, Oct 8, 2020 at 6:22 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Oct 1, 2020 at 12:50 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer <fweimer@redhat.com> wrote:
> > > >
> > > > * H. J. Lu:
> > > >
> > > > > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> > > > > index dadec5d58f..65ab29123d 100644
> > > > > --- a/sysdeps/x86/cacheinfo.c
> > > > > +++ b/sysdeps/x86/cacheinfo.c
> > > > > @@ -16,7 +16,9 @@
> > > > >     License along with the GNU C Library; if not, see
> > > > >     <https://www.gnu.org/licenses/>.  */
> > > > >
> > > > > -#if IS_IN (libc)
> > > > > +/* NB: In libc.a, this file is included in libc-static.c.  In libc.so,
> > > > > +   this file is standalone.  */
> > > > > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES_H)
> > > >
> > > > libc-static.c should be libc-start.c, I believe.  The “defined
> > > > _PRIVATE_CPU_FEATURES_H” part seems rather indirect.  What exactly are
> > > > you trying to accomplish here?
> > > >
> > > > It looks to me as if this file should included in libc.so, but not
> > > > pulled into ld.so via the rebuild, so maybe you can add an empty
> > > > sysdeps/x86/rtld-cacheinfo.c file instead?
> > > >
> > >
> > > Here is the updated patch.   I also moved files around to prepare
> > > for moving x86 processor cache info to cpu_features in ld.so to
> > > support --list-tunables.
> > >
> >
> > PING:
> >
> > https://sourceware.org/pipermail/libc-alpha/2020-October/118228.html
> >
>
> I will check it in tomorrow if there are no objections.
>
> Thanks.
>
> --
> H.J.

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203]
  2022-05-02 13:59                               ` PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] Sunil Pandey
@ 2022-05-03 18:51                                 ` Sunil Pandey
  0 siblings, 0 replies; 2+ messages in thread
From: Sunil Pandey @ 2022-05-03 18:51 UTC (permalink / raw)
  To: H.J. Lu, Libc-stable Mailing List; +Cc: Florian Weimer, H.J. Lu via Libc-alpha

On Mon, May 2, 2022 at 6:59 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> On Thu, Oct 15, 2020 at 5:54 AM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > On Thu, Oct 8, 2020 at 6:22 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Oct 1, 2020 at 12:50 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > >
> > > > On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer <fweimer@redhat.com> wrote:
> > > > >
> > > > > * H. J. Lu:
> > > > >
> > > > > > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> > > > > > index dadec5d58f..65ab29123d 100644
> > > > > > --- a/sysdeps/x86/cacheinfo.c
> > > > > > +++ b/sysdeps/x86/cacheinfo.c
> > > > > > @@ -16,7 +16,9 @@
> > > > > >     License along with the GNU C Library; if not, see
> > > > > >     <https://www.gnu.org/licenses/>.  */
> > > > > >
> > > > > > -#if IS_IN (libc)
> > > > > > +/* NB: In libc.a, this file is included in libc-static.c.  In libc.so,
> > > > > > +   this file is standalone.  */
> > > > > > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES_H)
> > > > >
> > > > > libc-static.c should be libc-start.c, I believe.  The “defined
> > > > > _PRIVATE_CPU_FEATURES_H” part seems rather indirect.  What exactly are
> > > > > you trying to accomplish here?
> > > > >
> > > > > It looks to me as if this file should included in libc.so, but not
> > > > > pulled into ld.so via the rebuild, so maybe you can add an empty
> > > > > sysdeps/x86/rtld-cacheinfo.c file instead?
> > > > >
> > > >
> > > > Here is the updated patch.   I also moved files around to prepare
> > > > for moving x86 processor cache info to cpu_features in ld.so to
> > > > support --list-tunables.
> > > >
> > >
> > > PING:
> > >
> > > https://sourceware.org/pipermail/libc-alpha/2020-October/118228.html
> > >
> >
> > I will check it in tomorrow if there are no objections.
> >
> > Thanks.
> >
> > --
> > H.J.
>
> I would like to backport this patch to release branches.
> Any comments or objections?
>
> --Sunil

I have to stop backporting at 2.33.

There is major x86 restructuring and inter patch dependency in the 2.32 branch.
Resolving backport conflict in the 2.32 branch has a cascading effect
on existing
patches.

--Sunil

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-03 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200918160709.949608-1-hjl.tools@gmail.com>
     [not found] ` <20200918160709.949608-2-hjl.tools@gmail.com>
     [not found]   ` <87imby6obw.fsf@oldenburg2.str.redhat.com>
     [not found]     ` <CAMe9rOo_OUmsikKWj_pXiy-G+NJZGGJwzn2_YTczXPvd09FaRA@mail.gmail.com>
     [not found]       ` <87y2ku574k.fsf@oldenburg2.str.redhat.com>
     [not found]         ` <CAMe9rOqjzDHL+O04FSCzRdnANJK0_3o5pDCd2UGyFsce+mU8Kg@mail.gmail.com>
     [not found]           ` <87lfgu56c8.fsf@oldenburg2.str.redhat.com>
     [not found]             ` <CAMe9rOoR_m6L7XUyMBjtqT_c80eiNUjuSOD112iX-Wne6cCYvQ@mail.gmail.com>
     [not found]               ` <87pn663qm5.fsf@oldenburg2.str.redhat.com>
     [not found]                 ` <CAMe9rOr7g6YCD3V+B-bUGvRbzZbBfMB5pYuiOibunBYpdaT57g@mail.gmail.com>
     [not found]                   ` <87ft71yq64.fsf@oldenburg2.str.redhat.com>
     [not found]                     ` <CAMe9rOpJWfY8rrNYycusxdnfEXe70ehXK2EJ1NCpNLPks=nEXw@mail.gmail.com>
     [not found]                       ` <87362yl4fh.fsf@oldenburg2.str.redhat.com>
     [not found]                         ` <CAMe9rOpfdPx_0nKT74Ay6zZ7AQBB2Emk7JQtNzk46_+gue9gwg@mail.gmail.com>
     [not found]                           ` <CAMe9rOpR=hoQwxMouCGE0mtDD5U3OYc9FWvOEtNEqpg2rbbHVQ@mail.gmail.com>
     [not found]                             ` <CAMe9rOpK-d_0u08j7b5PecErpM+FDxK0cSYXwxG776RMXB8o0Q@mail.gmail.com>
2022-05-02 13:59                               ` PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] Sunil Pandey
2022-05-03 18:51                                 ` Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).