From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by sourceware.org (Postfix) with ESMTPS id 2EE71395A451; Tue, 3 May 2022 18:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EE71395A451 Received: by mail-vk1-xa35.google.com with SMTP id y27so8384623vkl.8; Tue, 03 May 2022 11:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zruNAVAs2rRCc3onqvXegHaMS23T0bPHFpwiFp5ItAU=; b=qIk0JTjcf5BN93bYgY6rD4Z9XmeNqC2ZzXjWX7EB+UXNuOsd762AHWx0QlkvHgTlWP 0+0mai52M/qjo5VLzwA6Nc4rAcXubcEHtKAyhrxrW0UG0ufBUCSbeGpgb5xv9NFZ/Q4y d2dfQOhceRWMAKYARsB6JzrxHcKA1vfd0ZoyO9Y3O7u5nt+C2m0T4Cbj7LwQgXWdp7OO VuD73gK0uD1/2JimU8CGHF1itkw1jQNFs+h2Bjp+8ZB5sr8PQTwRa3OMd4Wjx4k9x/iI ceC5OJyH8WyXCosDhK86qElMf6P3/+AyxkxE562+Xv0KJtqb74B+chQODmn+xi1mKBY1 mS8A== X-Gm-Message-State: AOAM530/vX2f3qePhRLz825dtC4I1hIFNzAXEzj9n06GQxsQSYTw44eG 48o5O8Ri7KeC4qJ8+uQYBpuT64pnLwdOPQM/LHeTVxRO X-Google-Smtp-Source: ABdhPJwo6llGztncH9FAmKKe3nYGrucur6HDbtZZsrqNijractMn3TOJFXDeiUYw7y0AAOxLOTrhg+xPag0ymDBXMJs= X-Received: by 2002:a1f:c685:0:b0:349:9353:78dc with SMTP id w127-20020a1fc685000000b00349935378dcmr5095548vkf.11.1651603899510; Tue, 03 May 2022 11:51:39 -0700 (PDT) MIME-Version: 1.0 References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-2-hjl.tools@gmail.com> <87imby6obw.fsf@oldenburg2.str.redhat.com> <87y2ku574k.fsf@oldenburg2.str.redhat.com> <87lfgu56c8.fsf@oldenburg2.str.redhat.com> <87pn663qm5.fsf@oldenburg2.str.redhat.com> <87ft71yq64.fsf@oldenburg2.str.redhat.com> <87362yl4fh.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: Sunil Pandey Date: Tue, 3 May 2022 11:51:03 -0700 Message-ID: Subject: Re: PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] To: "H.J. Lu" , Libc-stable Mailing List Cc: Florian Weimer , "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2022 18:51:41 -0000 On Mon, May 2, 2022 at 6:59 AM Sunil Pandey wrote: > > On Thu, Oct 15, 2020 at 5:54 AM H.J. Lu via Libc-alpha > wrote: > > > > On Thu, Oct 8, 2020 at 6:22 AM H.J. Lu wrote: > > > > > > On Thu, Oct 1, 2020 at 12:50 PM H.J. Lu wrote: > > > > > > > > On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer = wrote: > > > > > > > > > > * H. J. Lu: > > > > > > > > > > > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c > > > > > > index dadec5d58f..65ab29123d 100644 > > > > > > --- a/sysdeps/x86/cacheinfo.c > > > > > > +++ b/sysdeps/x86/cacheinfo.c > > > > > > @@ -16,7 +16,9 @@ > > > > > > License along with the GNU C Library; if not, see > > > > > > . */ > > > > > > > > > > > > -#if IS_IN (libc) > > > > > > +/* NB: In libc.a, this file is included in libc-static.c. In = libc.so, > > > > > > + this file is standalone. */ > > > > > > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FE= ATURES_H) > > > > > > > > > > libc-static.c should be libc-start.c, I believe. The =E2=80=9Cde= fined > > > > > _PRIVATE_CPU_FEATURES_H=E2=80=9D part seems rather indirect. Wha= t exactly are > > > > > you trying to accomplish here? > > > > > > > > > > It looks to me as if this file should included in libc.so, but no= t > > > > > pulled into ld.so via the rebuild, so maybe you can add an empty > > > > > sysdeps/x86/rtld-cacheinfo.c file instead? > > > > > > > > > > > > > Here is the updated patch. I also moved files around to prepare > > > > for moving x86 processor cache info to cpu_features in ld.so to > > > > support --list-tunables. > > > > > > > > > > PING: > > > > > > https://sourceware.org/pipermail/libc-alpha/2020-October/118228.html > > > > > > > I will check it in tomorrow if there are no objections. > > > > Thanks. > > > > -- > > H.J. > > I would like to backport this patch to release branches. > Any comments or objections? > > --Sunil I have to stop backporting at 2.33. There is major x86 restructuring and inter patch dependency in the 2.32 bra= nch. Resolving backport conflict in the 2.32 branch has a cascading effect on existing patches. --Sunil