From: Sunil Pandey <skpgkp2@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] x86: Remove SSSE3 instruction for broadcast in memset.S (SSE2 Only)
Date: Tue, 3 May 2022 22:48:03 -0700 [thread overview]
Message-ID: <CAMAf5_f_m=iiWGfkDwuU+Vhjv0r9ze3pZs3jxrOLbdzkcDd7PA@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfKQf4G0FiayQGTjJpHYJXoSAeurgAdDD=kWBEwoFSKZmg@mail.gmail.com>
On Mon, Feb 7, 2022 at 12:56 PM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Mon, Feb 7, 2022 at 1:49 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Mon, Feb 7, 2022 at 11:39 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > commit b62ace2740a106222e124cc86956448fa07abf4d
> > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > Date: Sun Feb 6 00:54:18 2022 -0600
> > >
> > > x86: Improve vec generation in memset-vec-unaligned-erms.S
> > >
> > > Revert usage of 'pshufb' in broadcast logic as it is an SSSE3
> > > instruction and memset.S is restricted to only SSE2 instructions.
> > > ---
> > > sysdeps/x86_64/memset.S | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.S
> > > index ccf036be53..3f0517bbfc 100644
> > > --- a/sysdeps/x86_64/memset.S
> > > +++ b/sysdeps/x86_64/memset.S
> > > @@ -30,9 +30,10 @@
> > >
> > > # define MEMSET_SET_VEC0_AND_SET_RETURN(d, r) \
> > > movd d, %xmm0; \
> > > - pxor %xmm1, %xmm1; \
> > > - pshufb %xmm1, %xmm0; \
> > > - movq r, %rax
> > > + movq r, %rax; \
> > > + punpcklbw %xmm0, %xmm0; \
> > > + punpcklwd %xmm0, %xmm0; \
> > > + pshufd $0, %xmm0, %xmm0
> > >
> > > # define WMEMSET_SET_VEC0_AND_SET_RETURN(d, r) \
> > > movd d, %xmm0; \
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> > Thanks.
>
> Thanks pushed.
> >
> > --
> > H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
parent reply other threads:[~2022-05-04 5:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAFUsyfKQf4G0FiayQGTjJpHYJXoSAeurgAdDD=kWBEwoFSKZmg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_f_m=iiWGfkDwuU+Vhjv0r9ze3pZs3jxrOLbdzkcDd7PA@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).