From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by sourceware.org (Postfix) with ESMTPS id 4C5753858406; Wed, 4 May 2022 05:48:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C5753858406 Received: by mail-vs1-xe2e.google.com with SMTP id a127so270780vsa.3; Tue, 03 May 2022 22:48:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qGxfMGptHo5bglQj/9ab2+W+6knmEuJmvYXmSv5ineM=; b=iGOR3/bd+X/H95PbqcHBE3II/7ocys5lUy7HW29NcRdyV+c1KrujmTorysOcEW6xqm P0lqt18Eet5fWlLl6JRqVXfg/2lmAKj0zzS677txCIbMtRSqRAMX5zGOBwzolSmJr4B7 vIDouOW5Neg7UD0qFnuRF6gdj3YZImfsKm/483AEd13HdKl/z++8afisrqAfJYrfkGsm +pAW3/g9s0vaFSa0vmhkH+l1FOsZMP8Gk/hDGnnCzwYSj2N9uRCgqOrlytucwhDSyrxw kjEqM8DhtY4V91tzH/i8iDlsP/980BvOqiyUKquBg0SCwiF3oO/CvN9g9RIfleRzUTfL Uo2g== X-Gm-Message-State: AOAM531lPWi5NQYI2S5QHhfDQnn+QdCNrLpqvB+j+R/cjI8I2uwwnh3H GQafJ51lAQEYYxQNMZYHAvpfO9+klJN2ocfAprCUeg8szPo= X-Google-Smtp-Source: ABdhPJzzZdRIUChqOEecUS8EY4N2KS4f1MDQT+i6zl1a1jQDkg+RhWQGkQIK4915dtCMgdSSemHFfXpmoty6evt18Fw= X-Received: by 2002:a05:6102:3f0f:b0:32a:46dd:a908 with SMTP id k15-20020a0561023f0f00b0032a46dda908mr5809731vsv.48.1651643319741; Tue, 03 May 2022 22:48:39 -0700 (PDT) MIME-Version: 1.0 References: <20220207063854.3324172-1-goldstein.w.n@gmail.com> <20220207193906.2111349-1-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Tue, 3 May 2022 22:48:03 -0700 Message-ID: Subject: Re: [PATCH v2] x86: Remove SSSE3 instruction for broadcast in memset.S (SSE2 Only) To: Noah Goldstein , Libc-stable Mailing List Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 05:48:41 -0000 On Mon, Feb 7, 2022 at 12:56 PM Noah Goldstein via Libc-alpha wrote: > > On Mon, Feb 7, 2022 at 1:49 PM H.J. Lu wrote: > > > > On Mon, Feb 7, 2022 at 11:39 AM Noah Goldstein wrote: > > > > > > commit b62ace2740a106222e124cc86956448fa07abf4d > > > Author: Noah Goldstein > > > Date: Sun Feb 6 00:54:18 2022 -0600 > > > > > > x86: Improve vec generation in memset-vec-unaligned-erms.S > > > > > > Revert usage of 'pshufb' in broadcast logic as it is an SSSE3 > > > instruction and memset.S is restricted to only SSE2 instructions. > > > --- > > > sysdeps/x86_64/memset.S | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.S > > > index ccf036be53..3f0517bbfc 100644 > > > --- a/sysdeps/x86_64/memset.S > > > +++ b/sysdeps/x86_64/memset.S > > > @@ -30,9 +30,10 @@ > > > > > > # define MEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > > > movd d, %xmm0; \ > > > - pxor %xmm1, %xmm1; \ > > > - pshufb %xmm1, %xmm0; \ > > > - movq r, %rax > > > + movq r, %rax; \ > > > + punpcklbw %xmm0, %xmm0; \ > > > + punpcklwd %xmm0, %xmm0; \ > > > + pshufd $0, %xmm0, %xmm0 > > > > > > # define WMEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > > > movd d, %xmm0; \ > > > -- > > > 2.25.1 > > > > > > > LGTM. > > > > Reviewed-by: H.J. Lu > > > > Thanks. > > Thanks pushed. > > > > -- > > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil