From: Sunil Pandey <skpgkp2@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-stable@sourceware.org
Subject: Re: [PATCH 2/2] Don't make errlist.o[s].d depend on errlist-compat.h
Date: Thu, 9 May 2024 18:11:46 -0700 [thread overview]
Message-ID: <CAMAf5_fnTZmFZHU7Haqj4ssvPjq9CHb8qkMCbO+RxoUbw6He7Q@mail.gmail.com> (raw)
In-Reply-To: <20240509212228.2518737-3-hjl.tools@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
On Thu, May 9, 2024 at 2:22 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> stdio-common/errlist.o.d and stdio-common/errlist.os.d aren't generated
> alongside with stdio-common/errlist-compat.h. Don't make them depend on
> stdio-common/errlist-compat.h to avoid infinite loop with make-4.4. This
> fixes BZ #31330.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---
> sysdeps/gnu/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sysdeps/gnu/Makefile b/sysdeps/gnu/Makefile
> index 97fcb6fb90..26dc91d90a 100644
> --- a/sysdeps/gnu/Makefile
> +++ b/sysdeps/gnu/Makefile
> @@ -54,8 +54,7 @@ $(objpfx)errlist-compat.h: $(objpfx)errlist-compat.c
> generated += errlist-compat.c errlist-compat.h
>
> # This will force the generation above to happy if need be.
> -$(foreach o,$(object-suffixes) $(object-suffixes:=.d),\
> - $(objpfx)errlist$o): $(objpfx)errlist-compat.h
> +$(foreach o,$(object-suffixes),$(objpfx)errlist$o):
> $(objpfx)errlist-compat.h
> endif
>
> ifeq ($(subdir),login)
> --
> 2.45.0
>
>
LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
--Sunil
next prev parent reply other threads:[~2024-05-10 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 21:22 [PATCH 0/2] Make release branches compatible with make-4.4 H.J. Lu
2024-05-09 21:22 ` [PATCH 1/2] Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564] H.J. Lu
2024-05-10 1:11 ` Sunil Pandey
2024-05-09 21:22 ` [PATCH 2/2] Don't make errlist.o[s].d depend on errlist-compat.h H.J. Lu
2024-05-10 1:11 ` Sunil Pandey [this message]
2024-05-10 1:10 ` [PATCH 0/2] Make release branches compatible with make-4.4 Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMAf5_fnTZmFZHU7Haqj4ssvPjq9CHb8qkMCbO+RxoUbw6He7Q@mail.gmail.com \
--to=skpgkp2@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).