From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id EEDC13858400; Sun, 11 Sep 2022 19:57:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEDC13858400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-3321c2a8d4cso77938347b3.5; Sun, 11 Sep 2022 12:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5BjsQCbDtLYilALv4HBZs9BHx2NOUAIsRIiNEmDghh8=; b=O7DN54ULyJL/L+/M7wvUtjRxWZmpzGpVrATi41VnLlGhb+X9a2zSf9/pofRNFC2S2N fNeGUSfZX5eYf8KgW8sHDCDJEuKaosoOg8rutWvV9vc7Vt8C5XuR7dFlXwIHb/vbNRT4 n3h8s2ck4+aCVofqnmNBgcVreHMPHg2MIHyN110nz0XH6lxnH/FZj2cVUPUQs71YaXeg faV3gpLcL9Yo7fzIP0Gfagc1kBeu0EFQ6tfqhSE6GMX5wN0OjnyHXiRhguYTcFNjzONw 16ud2gGrz+5r/ObLV/22sTjEEUtZWRYR35zCRYmNZ67DPHO9QcBGua5kfAbUcEth3ME8 /hng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5BjsQCbDtLYilALv4HBZs9BHx2NOUAIsRIiNEmDghh8=; b=5Me3OLwWs+Z/kyl+W4OgdMXT6gDI9Ty/kahld84MsADbQn2QHjvbHwR3JrJSbvFOrk n/blZysyPDmzyMRSmofxpa6H++TzmVeGoaxdQjqObE9qRcCf/kzHFRAvyLI7K2DrKGQU uIUY2KzzeYjz2/gITnkkQf4gCdi83xAKI/lzcAuksnhdaxC+7LE67IqPP2e7rOxIDKNd R3yxH/YJWcajAeI8sPb1IcRNXDSjL/nJiNafC04vO4IDty5SizRHTpGfreg3UPOMDdxV eGIRKUKc8FMqvfrYLU+HY51TebUnK5baoqGQ8sNt/szcDmBw4+bob95roWSWcSXsfqd1 3ifg== X-Gm-Message-State: ACgBeo3DpCOLaw7PdcWdHs7YGe2QUbpt3bkDrXfS3FRrx3y1HDUZ24ym zI9lJrdRd9hRtY9i+/H0ysTJsRjgAAOShgK+cD2IhfygOjU= X-Google-Smtp-Source: AA6agR7BdsWRdkOTF5EH/vOKIQWcODW65PhPlA6QhjyHmyNZ4CtOOIt7nK2XcfUtHmztrkVTAsTnLdP4E1ymdmKInPY= X-Received: by 2002:a81:5ca:0:b0:348:a02b:2928 with SMTP id 193-20020a8105ca000000b00348a02b2928mr13547535ywf.390.1662926254333; Sun, 11 Sep 2022 12:57:34 -0700 (PDT) MIME-Version: 1.0 References: <20210623222846.2162301-1-hjl.tools@gmail.com> <20210623222846.2162301-2-hjl.tools@gmail.com> In-Reply-To: <20210623222846.2162301-2-hjl.tools@gmail.com> From: Sunil Pandey Date: Sun, 11 Sep 2022 12:56:58 -0700 Message-ID: Subject: Re: [PATCH v8 1/4] math: redirect roundeven function To: "H.J. Lu" , Libc-stable Mailing List , Florian Weimer Cc: GNU C Library , Shen-Ta Hsieh Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 23, 2021 at 3:32 PM H.J. Lu via Libc-alpha wrote: > > From: Shen-Ta Hsieh > > This patch redirect roundeven function for futhermore changes. > > Signed-off-by: Shen-Ta Hsieh > Reviewed-by: H.J. Lu > --- > include/math.h | 2 +- > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++- > sysdeps/ieee754/float128/s_roundevenf128.c | 1 + > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++ > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 + > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 + > 6 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/include/math.h b/include/math.h > index e1c2a4eb64..b4772d3d3b 100644 > --- a/include/math.h > +++ b/include/math.h > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling) > libm_hidden_proto (__issignalingf) > libm_hidden_proto (__exp) > libm_hidden_proto (__expf) > -libm_hidden_proto (__roundeven) > > # if !defined __NO_LONG_DOUBLE_MATH \ > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 0 > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x) > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS) > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS) > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS) > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS) > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS) > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS) > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS) > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/dbl-64/s_roundeven.c > index 943b2c634c..5deff3bb8a 100644 > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c > @@ -16,6 +16,7 @@ > License along with the GNU C Library; if not, see > . */ > > +#define NO_MATH_REDIRECT > #include > #include > #include > @@ -66,5 +67,6 @@ __roundeven (double x) > INSERT_WORDS64 (x, ix); > return x; > } > -hidden_def (__roundeven) > +#ifndef __roundeven > libm_alias_double (__roundeven, roundeven) > +#endif > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/ieee754/float128/s_roundevenf128.c > index 5a9b3f395f..e0faf727f6 100644 > --- a/sysdeps/ieee754/float128/s_roundevenf128.c > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c > @@ -1,2 +1,3 @@ > +#define NO_MATH_REDIRECT > #include > #include "../ldbl-128/s_roundevenl.c" > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/flt-32/s_roundevenf.c > index ae54365bbe..2cc0d7b001 100644 > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c > @@ -17,6 +17,7 @@ > License along with the GNU C Library; if not, see > . */ > > +#define NO_MATH_REDIRECT > #include > #include > #include > @@ -67,4 +68,6 @@ __roundevenf (float x) > SET_FLOAT_WORD (x, ix); > return x; > } > +#ifndef __roundevenf > libm_alias_float (__roundeven, roundeven) > +#endif > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > index 02765be0e0..7c9c11fad2 100644 > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > @@ -17,6 +17,7 @@ > License along with the GNU C Library; if not, see > . */ > > +#define NO_MATH_REDIRECT > #include > #include > #include > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > index 8340116ed8..f826829c31 100644 > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > @@ -17,6 +17,7 @@ > License along with the GNU C Library; if not, see > . */ > > +#define NO_MATH_REDIRECT > #include > #include > #include > -- > 2.31.1 > I would like to backport this patch to release branch 2.33. Any comments/suggestions or objections on this. commit 447954a206837b5f153869cfeeeab44631c3fac9 Author: Shen-Ta Hsieh Date: Mon May 24 09:43:10 2021 +0800 math: redirect roundeven function This patch redirect roundeven function for futhermore changes. Signed-off-by: Shen-Ta Hsieh Reviewed-by: H.J. Lu