From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id A49403858426 for ; Sat, 13 Apr 2024 18:05:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A49403858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A49403858426 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713031524; cv=none; b=Ma5vTHsQGvN8cbv5OdyA2NrnRgZPJrVjgad8639M1lHz5SiCIFpftqMLFH+uz0DLUq5q4ymyLg0iCGfnUW9qPa4WKMaOM5jfONbe4TUqKTs3KMq9TV44JDjgfH+DV67haFwkSH3ISR+pVL11ayOYiwCTQbvDFlsqgvedfk65WOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713031524; c=relaxed/simple; bh=RqvidlWNowMWk9cCbKiXUfcjjOKwGqO314nGqSOFVY4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=RHT0BnSrJeyJtiVONtJlFQoQZgweOXhdimz+TUYvGGRW6CXSsN/kltSOQzH177rFaoEeQB75j5Shq5XA21yNkCSekzhj7V1l5kfA31fikg9E3Ub7hmO0g2Puyt6XhkiN6foAfdDFqrSkeUw/ZyOS/poV8HkGsySTgHgMtV1sCmg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-61ab31d63edso2237647b3.1 for ; Sat, 13 Apr 2024 11:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713031521; x=1713636321; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fdSnIE5yFfcAda1a9NyTMsbVrxNN4+dO3zMxxKPdBCo=; b=mgYfm1n0JZk2imV3p2vEUqUeox5B7jjXB/1vS7d0OHdyy1yMAvxw0tsMa4Nl155JZe 6olxqeY0PjLhtdLLLX1d5VU/f6LuZbDGiSRwg6ncAwsmR5FBPBTYLXk+YjVsqJbe7C5p j8lvx6rYSxP19KJA/IIIaQW2Kzpofu55z2c3oWa0pTgezhlMhRAbGUrg+K6JRREXo39i 4Wynf/uwFRwL8aKoX6cSbZRyZQW6IY7hbX2skXFEwQJonbXYmBolAsLDhCoL+R53TZFj 7Uy/yIMelYz1M9gYLQzJFpXR6Uj54haJw+htGO+txN2NU1Z2lTkQmwZ9TqanGkd1wOUT DtLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713031521; x=1713636321; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fdSnIE5yFfcAda1a9NyTMsbVrxNN4+dO3zMxxKPdBCo=; b=QwLjsFFNQ4IdO2aq68nyeE13r4PY4vKN1yvTI6VjmxoZzSB1HeddSLcNHINlKPC4PW E6zjtXJZx60fKmrGj8g6Mp3t7vtHOhZmWwpexkSNaqJxePftPtZ/fhENt7TqWLditlZK 66e/QguqcdYpQAk0cYtdMQ/B9DkwZ6pvyMNQGW64auZQqkxjoFIUDXobE2DROMrbNcBd 27BuQpnd+XjN6e3swL3+ol46ForY1KCsFcLMGAJcbqagU/DK9op3rgy61gs44vDN6AI+ gymZ0/MSjW2Tkfww1mJKVNazgjl6bQ0r+sUyKQw+Y3dS9iH+2zHEHr0d5Hz86KvaRYG8 7fkw== X-Forwarded-Encrypted: i=1; AJvYcCXjl6yo4MMLUvDXqnLqFmmcOCwP4P9RzOu6c6lVyUvauefEiBR+XD1Bak1aSLPQv2uePKBeZhBdkKfXfCGQQxnaq0y3VWUb/77nLg== X-Gm-Message-State: AOJu0YwMnBnG1mrFy0BArPRySslyu8T955N9oCo1YcBF9DJg5p1jBt1U RXs5b2uh54GNi4qcQf7XUkkY26XFfooJ4v+eIZ7dZgAJwmbbErq+kTM9yv5BzEGx2RW/3RE9hoB cAQFn7ykGmQGO/ykrOml+nwl2hVxTBKAy X-Google-Smtp-Source: AGHT+IEfUXMbHfZhPIRilLkl04HTj6G1bI8bN6dtDeTWukDvO9P37+MPg1rxHfZOa9nyxwoOyy4F0jDcEEcXq/P61/E= X-Received: by 2002:a81:cf0b:0:b0:615:11fa:a7a0 with SMTP id u11-20020a81cf0b000000b0061511faa7a0mr3787762ywi.24.1713031520945; Sat, 13 Apr 2024 11:05:20 -0700 (PDT) MIME-Version: 1.0 References: <20240302003843.3333713-1-skpgkp2@gmail.com> <87h6g51773.fsf@oldenburg.str.redhat.com> In-Reply-To: <87h6g51773.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Sat, 13 Apr 2024 11:04:44 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Simplify minimum ISA check ifdef conditional with if To: Florian Weimer Cc: Sunil K Pandey , Libc-stable Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 13, 2024 at 10:52=E2=80=AFAM Florian Weimer wrote: > > * H. J. Lu: > > > Should it also be backported to glibc 2.39 together with > > > > commit befe2d3c4dec8be2cdd01a47132e47bdb7020922 > > Author: H.J. Lu > > Date: Wed Feb 28 09:51:14 2024 -0800 > > > > x86-64: Don't use SSE resolvers for ISA level 3 or above > > This is the one that breaks valgrind, isn't it? No. -march=3Dx86-64-v3 triggers the valgrind error in flibc test. This commit fixes the -march=3Dx86-64-v3 build. commit b6e3898194bbae78910bbe9cd086937014961e45 Author: Sunil K Pandey Date: Thu Feb 29 17:57:02 2024 -0800 x86-64: Simplify minimum ISA check ifdef conditional with if updates this commit. Backporting the above commit makes the backported code look similar to upstream. > I think we'll do downstream backports of some of the x86-64 > optimizations, but in the past, there was pushback against doing those > upstream. > > Thanks, > Florian > --=20 H.J.