From: "H.J. Lu" <hjl.tools@gmail.com>
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: Noah Goldstein <goldstein.w.n@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5 2/2] x86: Optimize strlen-avx2.S
Date: Wed, 28 Sep 2022 12:23:46 -0700 [thread overview]
Message-ID: <CAMe9rOoO9wAJ412qgATRFKXj8XUiXKp2APLkSg6iKLSVZ2X9eg@mail.gmail.com> (raw)
In-Reply-To: <CAMAf5_eoqSNp+OwjH-wtqdEbNn1ty=b5szWAESU9cZRxzqE2Cw@mail.gmail.com>
On Wed, Sep 28, 2022 at 12:09 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> On Wed, Sep 28, 2022 at 11:24 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Wed, Sep 28, 2022 at 6:55 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> > >
> > > Attached patch fixes BZ# 29611.
> > >
> > > I would like to backport it to 2.32,2.31,2.30,2.29 and 2.29. Let me know
> > > if there is any objection.
> >
> > It doesn't fully fix BZ #29611. Like Noah mentioned, we need to add
> > BMI2 check to ifunc-impl-list.c for all functions which use "ifunc-avx2.h".
> >
> >
> > H.J.
>
> Pulling up corresponding patches are extremely difficult as they are not
> modular. I can modify existing patches (as posted on bug report) to
> incorporate ifunc-impl-list.c functionality. If it is OK?
Please mention BZ #29611 in the commit log of the backport and submit
a separate patch to fully fix BZ #29611. We should use a patch set for
BZ #29611.
> For backporting small incremental changes are preferred. Single monolithic
> patch makes backporting extremely difficult, if not impossible.
--
H.J.
next prev parent reply other threads:[~2022-09-28 19:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210419233607.916848-1-goldstein.w.n@gmail.com>
[not found] ` <20210419233607.916848-2-goldstein.w.n@gmail.com>
[not found] ` <YzAO/ictPso/Y5LS@aurel32.net>
[not found] ` <CAFUsyf+U==grKgr9ZivEHDYsj=Xxi0MXBtQDfkU-JBHxb0pq+A@mail.gmail.com>
2022-09-28 13:54 ` Sunil Pandey
2022-09-28 14:02 ` Darren Tristano
2022-09-28 14:42 ` Noah Goldstein
2022-09-28 14:54 ` Sunil Pandey
2022-09-28 15:00 ` Noah Goldstein
2022-09-28 18:24 ` H.J. Lu
2022-09-30 13:19 ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano
2022-09-28 18:23 ` [PATCH v5 2/2] x86: Optimize strlen-avx2.S H.J. Lu
2022-09-28 19:09 ` Sunil Pandey
2022-09-28 19:23 ` H.J. Lu [this message]
2022-09-30 13:19 ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano
2022-10-04 21:19 ` [PATCH v5 2/2] x86: Optimize strlen-avx2.S Aurelien Jarno
2022-10-04 21:29 ` H.J. Lu
2022-10-05 1:10 ` Sunil Pandey
2022-10-05 14:23 ` Noah Goldstein
2022-10-05 16:35 ` Sunil Pandey
2022-10-05 17:11 ` Aurelien Jarno
2022-10-05 18:34 ` Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoO9wAJ412qgATRFKXj8XUiXKp2APLkSg6iKLSVZ2X9eg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).