I will backport it to 2.28 branch by the end of this week. H.J. ---------- Forwarded message ---------- From: H.J. Lu Date: Wed, Sep 12, 2018 at 8:20 AM Subject: Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S To: Florian Weimer Cc: Terry Guo , GNU C Library On Wed, Sep 12, 2018 at 4:59 AM, Florian Weimer wrote: > On 09/12/2018 01:57 PM, H.J. Lu wrote: >> >> On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer >> wrote: >>> >>> On 09/07/2018 09:06 AM, Terry Guo wrote: >>>> >>>> >>>> + /* Clearing frame pointer is insufficient, use CFI. */ >>>> + cfi_undefined (eip) >>> >>> >>> >>> Isn't this a separate fix? >> >> >> Since _start now includes CFI, without "cfi_undefined (eip)", unwinder >> may not >> terminate at _start and one unwind test will fail. > > > Ah! Please include this information in the commit message or ChangeLog > entry, too. This is the patch I am going to check in. -- H.J. -- H.J.