From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68869 invoked by alias); 19 Sep 2018 13:41:49 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 68856 invoked by uid 89); 19 Sep 2018 13:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=forwarded, U*n, ah, HTo:U*libc-stable X-Spam-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-ot1-f53.google.com Received: from mail-ot1-f53.google.com (HELO mail-ot1-f53.google.com) (209.85.210.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 13:41:46 +0000 Received: by mail-ot1-f53.google.com with SMTP id w17-v6so5800713otk.3 for ; Wed, 19 Sep 2018 06:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=r1XOBAiD08K6LyEfXJP/WsM4ZMi19zewrHKrzgNY2S0=; b=kQYySjXC3acpd6VNk+WU08o//wHY6blAiPzGjk+cimn6DzcJt7ItE8XdmPIVV9R7iJ ggH3MX3J+eHWw21mvfAV2mk/xKBC0wrKTm0dtYtowCKF5p5dYN3OulLIKzbHf4Hw3nnv vzOeDMAU1twPgyqlWuT9W4PYCM0fhkYk2FIC2HLxYLi+UNZ61r2pPoQgER6FKkMrHofV K0WVdu7C23lh/AQouKWw1UAZOFvPyVToLaQbXM9v7ZvU74RDgJJE+yEa2NeBNOInqgP7 gxU6H/Md8cBEDMTa2muNb9YaErKjOal/719RXDoJOeJ0OQOuyfFxmzIY3AIXf30TklQA cdgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=r1XOBAiD08K6LyEfXJP/WsM4ZMi19zewrHKrzgNY2S0=; b=emsW5yEIB0KKBZNmuOS138sFnhs2P87oUmiL+Mlmk3wlKXoChgOAMVCjm5rKMZ5vqp aAGo8tHfWwhCIfsH8jzuClGE1IP09JrWYSCy7iBqelZdmh1vs8rNPu3tKH0It5J2oKA9 +XrbVMd1jBYJXK0xRmS6denczV1XteXHAocvLgLCzt9HhVV1py8dv+E6S+lUz/w7GnPu WcZDyU3O9bwzK1cMlcBnYf39B/LoZR4UiG1C4+hUEroiHt4ITWrHDEkDYTrIj3ulnQlU HvNvXISfO0Kl4MVCgxeZCjfPZcT03Y4x2SO5ve82VnrDW3a8S1RWyl7RHpNm/sJ+ALZc gm6w== X-Gm-Message-State: APzg51C2f4bRuuOiIwlHzRIwtd8LhTsFvgJ6H+QjGxaka3Oo+Z0CLi9f f9cirRuF9ubYwWAZs7rWeN5wtqcc9b+wraToBHwIsw== X-Google-Smtp-Source: ANB0VdaYf9uj41iy4JA2Adq5v9BsTaN0nTOGyB7DnkUJ0ckpkEX7w5ptCpOS/GwkbwC7w/GbMURrkwrO2vOj7J1xo4Y= X-Received: by 2002:a9d:422b:: with SMTP id q43-v6mr19735242ote.289.1537364504828; Wed, 19 Sep 2018 06:41:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:711c:0:0:0:0:0 with HTTP; Wed, 19 Sep 2018 06:41:44 -0700 (PDT) From: "H.J. Lu" Date: Mon, 01 Jan 2018 00:00:00 -0000 Message-ID: Subject: [2.28 patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S To: Libc-stable Mailing List Content-Type: multipart/mixed; boundary="000000000000337cd905763991fa" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00002.txt.bz2 --000000000000337cd905763991fa Content-Type: text/plain; charset="UTF-8" Content-length: 1086 I will backport it to 2.28 branch by the end of this week. H.J. ---------- Forwarded message ---------- From: H.J. Lu Date: Wed, Sep 12, 2018 at 8:20 AM Subject: Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S To: Florian Weimer Cc: Terry Guo , GNU C Library On Wed, Sep 12, 2018 at 4:59 AM, Florian Weimer wrote: > On 09/12/2018 01:57 PM, H.J. Lu wrote: >> >> On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer >> wrote: >>> >>> On 09/07/2018 09:06 AM, Terry Guo wrote: >>>> >>>> >>>> + /* Clearing frame pointer is insufficient, use CFI. */ >>>> + cfi_undefined (eip) >>> >>> >>> >>> Isn't this a separate fix? >> >> >> Since _start now includes CFI, without "cfi_undefined (eip)", unwinder >> may not >> terminate at _start and one unwind test will fail. > > > Ah! Please include this information in the commit message or ChangeLog > entry, too. This is the patch I am going to check in. -- H.J. -- H.J. --000000000000337cd905763991fa Content-Type: text/x-patch; charset="US-ASCII"; name="0001-i386-Use-ENTRY-and-END-in-start.S-BZ-23606.patch" Content-Disposition: attachment; filename="0001-i386-Use-ENTRY-and-END-in-start.S-BZ-23606.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jlzajpw90 Content-length: 4319 RnJvbSA0MDJlYTA1NDVjOWVmYTQ5YmUxNTk2NTIyZTUxN2IxOTZkMTM5N2E4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgNSBTZXAgMjAxOCAwNTo1 ODo0NSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGkzODY6IFVzZSBFTlRSWSBh bmQgRU5EIGluIHN0YXJ0LlMgW0JaICMyMzYwNl0KCldyYXBwaW5nIHRoZSBf c3RhcnQgZnVuY3Rpb24gd2l0aCBFTlRSWSBhbmQgRU5EIHRvIGluc2VydCBF TkRCUjMyIGF0CmZ1bmN0aW9uIGVudHJ5IHdoZW4gQ0VUIGlzIGVuYWJsZWQu ICBTaW5jZSBfc3RhcnQgbm93IGluY2x1ZGVzIENGSSwKd2l0aG91dCAiY2Zp X3VuZGVmaW5lZCAoZWlwKSIsIHVud2luZGVyIG1heSBub3QgdGVybWluYXRl IGF0IF9zdGFydAphbmQgd2Ugd2lsbCBnZXQKClByb2dyYW0gcmVjZWl2ZWQg c2lnbmFsIFNJR1NFR1YsIFNlZ21lbnRhdGlvbiBmYXVsdC4KMHhmN2RjNjYx ZSBpbiA/PyAoKSBmcm9tIC9saWIvbGliZ2NjX3Muc28uMQpNaXNzaW5nIHNl cGFyYXRlIGRlYnVnaW5mb3MsIHVzZTogZG5mIGRlYnVnaW5mby1pbnN0YWxs IGxpYmdjYy04LjIuMS0zLjAuZmMyOC5pNjg2CihnZGIpIGJ0CiAjMCAgMHhm N2RjNjYxZSBpbiA/PyAoKSBmcm9tIC9saWIvbGliZ2NjX3Muc28uMQogIzEg IDB4ZjdkYzdjMTggaW4gX1Vud2luZF9CYWNrdHJhY2UgKCkgZnJvbSAvbGli L2xpYmdjY19zLnNvLjEKICMyICAweGY3ZjBkODA5IGluIF9fR0lfX19iYWNr dHJhY2UgKGFycmF5PWFycmF5QGVudHJ5PTB4ZmZmZmM3ZDAsCiAgICBzaXpl PXNpemVAZW50cnk9MjApIGF0IC4uL3N5c2RlcHMvaTM4Ni9iYWNrdHJhY2Uu YzoxMjcKICMzICAweDA4MDQ5MjU0IGluIGNvbXBhcmUgKHAxPXAxQGVudHJ5 PTB4ZmZmZmNhZDAsIHAyPXAyQGVudHJ5PTB4ZmZmZmNhZDQpCiAgICBhdCBi YWNrdHJhY2UtdHN0LmM6MTIKICM0ICAweGY3ZTJhMjhjIGluIG1zb3J0X3dp dGhfdG1wIChwPXBAZW50cnk9MHhmZmZmY2E1YywgYj1iQGVudHJ5PTB4ZmZm ZmNhZDAsCiAgICBuPW5AZW50cnk9MikgYXQgbXNvcnQuYzo2NQogIzUgIDB4 ZjdlMjlmNjQgaW4gbXNvcnRfd2l0aF90bXAgKG49MiwgYj0weGZmZmZjYWQw LCBwPTB4ZmZmZmNhNWMpCiAgICBhdCBtc29ydC5jOjUzCiAjNiAgbXNvcnRf d2l0aF90bXAgKHA9cEBlbnRyeT0weGZmZmZjYTVjLCBiPWJAZW50cnk9MHhm ZmZmY2FkMCwgbj1uQGVudHJ5PTUpCiAgICBhdCBtc29ydC5jOjUzCiAjNyAg MHhmN2UyOWY2NCBpbiBtc29ydF93aXRoX3RtcCAobj01LCBiPTB4ZmZmZmNh ZDAsIHA9MHhmZmZmY2E1YykKICAgIGF0IG1zb3J0LmM6NTMKICM4ICBtc29y dF93aXRoX3RtcCAocD1wQGVudHJ5PTB4ZmZmZmNhNWMsIGI9YkBlbnRyeT0w eGZmZmZjYWQwLCBuPW5AZW50cnk9MTApCiAgICBhdCBtc29ydC5jOjUzCiAj OSAgMHhmN2UyOWY2NCBpbiBtc29ydF93aXRoX3RtcCAobj0xMCwgYj0weGZm ZmZjYWQwLCBwPTB4ZmZmZmNhNWMpCiAgICBhdCBtc29ydC5jOjUzCiAjMTAg bXNvcnRfd2l0aF90bXAgKHA9cEBlbnRyeT0weGZmZmZjYTVjLCBiPWJAZW50 cnk9MHhmZmZmY2FkMCwgbj1uQGVudHJ5PTIwKQogICAgYXQgbXNvcnQuYzo1 MwogIzExIDB4ZjdlMmE1YjYgaW4gbXNvcnRfd2l0aF90bXAgKG49MjAsIGI9 MHhmZmZmY2FkMCwgcD0weGZmZmZjYTVjKQogICAgYXQgbXNvcnQuYzoyOTcK ICMxMiBfX0dJX19fcXNvcnRfciAoYj1iQGVudHJ5PTB4ZmZmZmNhZDAsIG49 bkBlbnRyeT0yMCwgcz1zQGVudHJ5PTQsCiAgICBjbXA9Y21wQGVudHJ5PTB4 ODA0OTIzMCA8Y29tcGFyZT4sIGFyZz1hcmdAZW50cnk9MHgwKSBhdCBtc29y dC5jOjI5NwogIzEzIDB4ZjdlMmE4NGQgaW4gX19HSV9xc29ydCAoYj1iQGVu dHJ5PTB4ZmZmZmNhZDAsIG49bkBlbnRyeT0yMCwgcz1zQGVudHJ5PTQsCiAg ICBjbXA9Y21wQGVudHJ5PTB4ODA0OTIzMCA8Y29tcGFyZT4pIGF0IG1zb3J0 LmM6MzA4CiAjMTQgMHgwODA0OTBmNiBpbiBtYWluIChhcmdjPTIsIGFyZ3Y9 MHhmZmZmY2JkNCkgYXQgYmFja3RyYWNlLXRzdC5jOjM5CgpGQUlMOiBkZWJ1 Zy9iYWNrdHJhY2UtdHN0CgoyMDE4LTA5LTEyICBILkouIEx1ICA8aG9uZ2pp dS5sdUBpbnRlbC5jb20+CgkgICAgWHVlcGVuZyBHdW8gIDx4dWVwZW5nLmd1 b0BpbnRlbC5jb20+CgoJW0JaICMyMzYwNl0KCSogc3lzZGVwcy9pMzg2L3N0 YXJ0LlM6IEluY2x1ZGUgPHN5c2RlcC5oPgoJKF9zdGFydCk6IFVzZSBFTlRS WS9FTkQgdG8gaW5zZXJ0IEVOREJSMzIgYXQgZW50cnkgd2hlbiBDRVQgaXMK CWVuYWJsZWQuICBBZGQgY2ZpX3VuZGVmaW5lZCAoZWlwKS4KClNpZ25lZC1v ZmYtYnk6IEguSi4gTHUgPGhqbC50b29sc0BnbWFpbC5jb20+Ci0tLQogc3lz ZGVwcy9pMzg2L3N0YXJ0LlMgfCAxMCArKysrKystLS0tCiAxIGZpbGUgY2hh bmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3N5c2RlcHMvaTM4Ni9zdGFydC5TIGIvc3lzZGVwcy9pMzg2L3N0 YXJ0LlMKaW5kZXggOTEwMzVmYTgzZi4uZTM1ZTliZDMxYiAxMDA2NDQKLS0t IGEvc3lzZGVwcy9pMzg2L3N0YXJ0LlMKKysrIGIvc3lzZGVwcy9pMzg2L3N0 YXJ0LlMKQEAgLTUyLDEwICs1MiwxMSBAQAogCQkJCQlOVUxMCiAqLwogCi0J LnRleHQKLQkuZ2xvYmwgX3N0YXJ0Ci0JLnR5cGUgX3N0YXJ0LEBmdW5jdGlv bgotX3N0YXJ0OgorI2luY2x1ZGUgPHN5c2RlcC5oPgorCitFTlRSWSAoX3N0 YXJ0KQorCS8qIENsZWFyaW5nIGZyYW1lIHBvaW50ZXIgaXMgaW5zdWZmaWNp ZW50LCB1c2UgQ0ZJLiAgKi8KKwljZmlfdW5kZWZpbmVkIChlaXApCiAJLyog Q2xlYXIgdGhlIGZyYW1lIHBvaW50ZXIuICBUaGUgQUJJIHN1Z2dlc3RzIHRo aXMgYmUgZG9uZSwgdG8gbWFyawogCSAgIHRoZSBvdXRlcm1vc3QgZnJhbWUg b2J2aW91c2x5LiAgKi8KIAl4b3JsICVlYnAsICVlYnAKQEAgLTEzMSw2ICsx MzIsNyBAQCBfc3RhcnQ6CiAxOgltb3ZsCSglZXNwKSwgJWVieAogCXJldAog I2VuZGlmCitFTkQgKF9zdGFydCkKIAogLyogVG8gZnVsZmlsbCB0aGUgU3lz dGVtIFYvaTM4NiBBQkkgd2UgbmVlZCB0aGlzIHN5bWJvbC4gIFl1Y2ssIGl0 J3Mgc28KICAgIG1lYW5pbmdsZXNzIHNpbmNlIHdlIGRvbid0IHN1cHBvcnQg bWFjaGluZXMgPCA4MDM4Ni4gICovCi0tIAoyLjE3LjEKCg== --000000000000337cd905763991fa--