From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 84AAA3A47405; Thu, 22 Apr 2021 17:09:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 84AAA3A47405 Received: by mail-oi1-x235.google.com with SMTP id k25so46505994oic.4; Thu, 22 Apr 2021 10:09:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QHMbzFjA1fddUCrFaEmn7311supV1Kic662caBVYmHc=; b=oqVy0h7/WeL1Wtx1yrqPzjMpW1La9lTswLrfXcJ7bazdL9W+RVAE/uQBhAjDQMkj0F yFVTmdsu8yZ0LzbAIdXrDSaoMvcFtiKzWFRhqnfedhATpTgCqpT+FSF91HyOmYy9PXWN PgB1otm0gZM+6fYdF8vssadukm76as9eqv9jcaTcWT998BHRUJc8raZXG3VJiNBKQ18d eZQs1o+84o++q6BbOGJhHvOWWXjEy5r7B9hrVDWGXnO9SAKMJN2C02/sQpMxzaz5/zEx UMgvzccgVYsd0qN/8kBEoE+oMTFJbdV7r/zIUXAw77Z42lH53FShJaXuPRpHHt8a5vPz mFKQ== X-Gm-Message-State: AOAM530eHwwZEUEoTvpOGaVC7j2m5bPQAxNyGt/fNdvp73yQTk09Hl66 W6nYJewqZUfGrL01l7Tav/a4HJgToFi0nglqLv3arM1CCmo= X-Google-Smtp-Source: ABdhPJz6sxwZX04VGO0JCTQjWvCj6pMeRUX8DE1NfM0a7DHC3EanPyKVp6jmqGNqy/+qqupA5XjjS54yrI8SVPlnbWc= X-Received: by 2002:aca:b208:: with SMTP id b8mr709086oif.79.1619111373963; Thu, 22 Apr 2021 10:09:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Thu, 22 Apr 2021 10:08:57 -0700 Message-ID: Subject: Re: [PATCH] x86: tst-cpu-features-supports.c: Update AMX check To: Joseph Myers , Libc-stable Mailing List Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 17:09:36 -0000 On Thu, Apr 22, 2021 at 10:08 AM Joseph Myers wrote: > > On Wed, 21 Apr 2021, H.J. Lu via Libc-alpha wrote: > > > On Wed, Apr 21, 2021 at 3:45 PM Joseph Myers wrote: > > > > > > With GCC mainline, I'm seeing glibc testsuite build failures for x86_64 > > > and x86: > > > > > > ../sysdeps/x86/tst-cpu-features-supports.c: In function 'do_test': > > > ../sysdeps/x86/tst-cpu-features-supports.c:62:3: error: parameter to builtin not valid: amx_bf16 > > > 62 | fails += CHECK_SUPPORTS (amx_bf16, AMX_BF16); > > > | ^~~~~ > > > ../sysdeps/x86/tst-cpu-features-supports.c:63:3: error: parameter to builtin not valid: amx_int8 > > > 63 | fails += CHECK_SUPPORTS (amx_int8, AMX_INT8); > > > | ^~~~~ > > > ../sysdeps/x86/tst-cpu-features-supports.c:64:3: error: parameter to builtin not valid: amx_tile > > > 64 | fails += CHECK_SUPPORTS (amx_tile, AMX_TILE); > > > | ^~~~~ > > > > > > https://sourceware.org/pipermail/libc-testresults/2021q2/007827.html > > > > > > The code in question is inside a conditional > > > > > > #if __GNUC_PREREQ (11, 1) > > > > > > so wasn't compiled until the GCC version number was increased to 12 (and > > > would probably start failing with GCC 11 branch as soon as 11.1 is > > > released). > > > > > > > Try this. > > That patch fixes the build failures for me. > > (Note: the fix ought to go on 2.33 branch as well, otherwise that branch > will fail to build the testsuite with GCC 11.1 release.) I will check it into master branch and backport it to 2.33 branch. Thanks. -- H.J.