* Re: [PATCH] x86: tst-cpu-features-supports.c: Update AMX check
[not found] ` <alpine.DEB.2.22.394.2104221707070.422054@digraph.polyomino.org.uk>
@ 2021-04-22 17:08 ` H.J. Lu
0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2021-04-22 17:08 UTC (permalink / raw)
To: Joseph Myers, Libc-stable Mailing List; +Cc: GNU C Library
On Thu, Apr 22, 2021 at 10:08 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Wed, 21 Apr 2021, H.J. Lu via Libc-alpha wrote:
>
> > On Wed, Apr 21, 2021 at 3:45 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > >
> > > With GCC mainline, I'm seeing glibc testsuite build failures for x86_64
> > > and x86:
> > >
> > > ../sysdeps/x86/tst-cpu-features-supports.c: In function 'do_test':
> > > ../sysdeps/x86/tst-cpu-features-supports.c:62:3: error: parameter to builtin not valid: amx_bf16
> > > 62 | fails += CHECK_SUPPORTS (amx_bf16, AMX_BF16);
> > > | ^~~~~
> > > ../sysdeps/x86/tst-cpu-features-supports.c:63:3: error: parameter to builtin not valid: amx_int8
> > > 63 | fails += CHECK_SUPPORTS (amx_int8, AMX_INT8);
> > > | ^~~~~
> > > ../sysdeps/x86/tst-cpu-features-supports.c:64:3: error: parameter to builtin not valid: amx_tile
> > > 64 | fails += CHECK_SUPPORTS (amx_tile, AMX_TILE);
> > > | ^~~~~
> > >
> > > https://sourceware.org/pipermail/libc-testresults/2021q2/007827.html
> > >
> > > The code in question is inside a conditional
> > >
> > > #if __GNUC_PREREQ (11, 1)
> > >
> > > so wasn't compiled until the GCC version number was increased to 12 (and
> > > would probably start failing with GCC 11 branch as soon as 11.1 is
> > > released).
> > >
> >
> > Try this.
>
> That patch fixes the build failures for me.
>
> (Note: the fix ought to go on 2.33 branch as well, otherwise that branch
> will fail to build the testsuite with GCC 11.1 release.)
I will check it into master branch and backport it to 2.33 branch.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] only message in thread