From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
 [IPv6:2607:f8b0:4864:20::1035])
 by sourceware.org (Postfix) with ESMTPS id 80DEC3858D20;
 Thu, 17 Feb 2022 19:22:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80DEC3858D20
Received: by mail-pj1-x1035.google.com with SMTP id b8so6534402pjb.4;
 Thu, 17 Feb 2022 11:22:49 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=A/vQMNoRoqvk1A/H9fCF5aVOOEdd0MCfUI58CV/jUAQ=;
 b=SXeYgTJlHvhCFgQb38Sy0B/Mu4zYoR8KTbgTrgt/3qyXju5sQmoUJkCHZMiePqsTM5
 iUwbr6RShCgAp1OsFoWOZ4Qe5IzQOUhD1KBvi2uqwXaabrCbS6Riry2YkFgTdDxSPrHR
 poEzJiDyP/ghn7vPin/PW8SSfbSop+gJkBNVsQ9nriQBvRHNOCROfxh1v4bVOSyqCqKD
 bjPaCl2OmyS1yBMA2u8bBpxuBpyyjGDIsBtnpqzjWYfJIZM5C1n/1JhljGVHLV+6UsH7
 OwSnB2AiwpavccID4U8NWXWKInvsQbLrVxfoim6EaMzp96T6tnsuoSjsjdKLtMCwr3ez
 ChKg==
X-Gm-Message-State: AOAM530wAImz3qNZ6qzHAQyAWYbGsmu0J/as8jvkBqJZFMZV+PEkuZu2
 QWhPFVbC5UFjYqNTym455wpR3JdIW3ULvkhS36DexUgh
X-Google-Smtp-Source: ABdhPJzVnW19R+Ggdx0sJguIT2cbH2FTiGOoHEIv+uDqlB6e1Tfj5dukN8bpMZtSw26eduKvJouG+0sGGV+pEks6Efo=
X-Received: by 2002:a17:902:e8cd:b0:14d:ce80:a995 with SMTP id
 v13-20020a170902e8cd00b0014dce80a995mr4188854plg.4.1645125768533; Thu, 17 Feb
 2022 11:22:48 -0800 (PST)
MIME-Version: 1.0
References: <20220217162831.417972-1-hjl.tools@gmail.com>
 <CAMAf5_ei=o4i2GKe07xSQg+32uA5Bq+PB3TNNwchTkr0zHevMg@mail.gmail.com>
 <CAMe9rOpmKwoZvnaqgijSrFb-7fmuVURqBOzfbZ=kqTVo5GjU3Q@mail.gmail.com>
 <CAFUsyfLtREaQMBwiazxq21LZu5DFah2ECuBOqtRGLZOLM-sJBg@mail.gmail.com>
In-Reply-To: <CAFUsyfLtREaQMBwiazxq21LZu5DFah2ECuBOqtRGLZOLM-sJBg@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 17 Feb 2022 11:22:12 -0800
Message-ID: <CAMe9rOpJ2Yi7qaQzxnNSuvX9RFotNpJcNAGWDeamiQRcYSaFTg@mail.gmail.com>
Subject: Re: [PATCH] string: Add a testcase for wcsncmp with SIZE_MAX [BZ
 #28755]
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Sunil Pandey <skpgkp2@gmail.com>, 
 Libc-stable Mailing List <libc-stable@sourceware.org>,
 GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-stable@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-stable mailing list <libc-stable.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-stable/>
List-Help: <mailto:libc-stable-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Feb 2022 19:22:51 -0000

On Thu, Feb 17, 2022 at 11:17 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Feb 17, 2022 at 1:06 PM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > On Thu, Feb 17, 2022 at 10:58 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> > >
> > > LGTM
> > >
> > > Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
> >
> > I am backporting this to release branches.
> We will also need to backport the change of target for the RTM + AVX2 versions.

Can you do that after it is landed on master branch?

Thanks.

>
> >
> > > On Thu, Feb 17, 2022 at 8:28 AM H.J. Lu via Libc-alpha
> > > <libc-alpha@sourceware.org> wrote:
> > > >
> > > > Verify that wcsncmp (L"abc", L"abd", SIZE_MAX) == 0.  The new test fails
> > > > without
> > > >
> > > > commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87
> > > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > > Date:   Sun Jan 9 16:02:21 2022 -0600
> > > >
> > > >     x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]
> > > >
> > > > and
> > > >
> > > > commit 7e08db3359c86c94918feb33a1182cd0ff3bb10b
> > > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > > Date:   Sun Jan 9 16:02:28 2022 -0600
> > > >
> > > >     x86: Fix __wcsncmp_evex in strcmp-evex.S [BZ# 28755]
> > > >
> > > > This is for BZ #28755.
> > > > ---
> > > >  string/test-strncmp.c | 13 +++++++++++++
> > > >  1 file changed, 13 insertions(+)
> > > >
> > > > diff --git a/string/test-strncmp.c b/string/test-strncmp.c
> > > > index df7cea4068..1a87f0e73e 100644
> > > > --- a/string/test-strncmp.c
> > > > +++ b/string/test-strncmp.c
> > > > @@ -445,6 +445,18 @@ check4 (void)
> > > >    check_result (impl, s1, s2, size, exp_result);
> > > >  }
> > > >
> > > > +static void
> > > > +check5 (void)
> > > > +{
> > > > +  const CHAR *s1 = L ("abc");
> > > > +  CHAR *s2 = STRDUP (s1);
> > > > +
> > > > +  FOR_EACH_IMPL (impl, 0)
> > > > +    check_result (impl, s1, s2, SIZE_MAX, 0);
> > > > +
> > > > +  free (s2);
> > > > +}
> > > > +
> > > >  static void
> > > >  check_overflow (void)
> > > >  {
> > > > @@ -569,6 +581,7 @@ test_main (void)
> > > >    check2 ();
> > > >    check3 ();
> > > >    check4 ();
> > > > +  check5 ();
> > > >
> > > >    printf ("%23s", "");
> > > >    FOR_EACH_IMPL (impl, 0)
> > > > --
> > > > 2.35.1
> > > >
> >
> >
> >
> > --
> > H.J.



-- 
H.J.