From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65863 invoked by alias); 19 Oct 2017 15:01:58 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 65844 invoked by uid 89); 19 Oct 2017 15:01:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=CFA X-Spam-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f66.google.com Received: from mail-oi0-f66.google.com (HELO mail-oi0-f66.google.com) (209.85.218.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 15:01:54 +0000 Received: by mail-oi0-f66.google.com with SMTP id c202so15373932oih.9; Thu, 19 Oct 2017 08:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=k6ld6tngRijOY0MyHO8cGzL/94LTMbCB1lzpR+6s/aU=; b=MaKCqRCyF6emcoA2sEu6WrRb4Usxj/znX0OkBMNUqfqF7s3RCOLI8gnInqNKub/tX2 vPORPze5kt9rpo0U5rEi1CxNHG1TXT7uIDWflxiSLA8iIfQop1FAd29xCNZTbKgrshe7 eckaZm8kSrtmtmtJSCiKofGX6wQBEtA+SykYLrSdLEyDqtqhdfYHSJrL5YgcRbAJA7Or BhqmXWJ9c/YhnlrmOuu1CAq2XT4KKLcRJuXOh8xsOCfhLn2eNIMoauHbX1mRLdpancSc fLli+DpKLap4IG0bvg/D/gQA9W46TfT4TYenSV00Lo7nITJiFW5IJEKXq5iamI85Xd2X 0IYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=k6ld6tngRijOY0MyHO8cGzL/94LTMbCB1lzpR+6s/aU=; b=H1Yud+yyZx9cerR0jf/m9oZewTT9nq1Vtqpxa56hVxyl4dE97i0J5FcMDqI1MAA1Jf 5n6bJOYnsqxE2HVXnTjO9S0aSV+4CM0KUFUcB5jshL3qsjsQQplEqhGYKo7rm7pOXftJ 8XItDb6raqpjYPXF0JimxRKs5qwViD/HVeUjXTzdPlPLVMcbmxHDDZVAOvHz9vo2R1uu MgeM41aulx85140Ky5paJcto5X8r/VzCAtwuuEPaPlCZ1MgExBcN6dv5tBpf2jbXtw3w Xdf6F2G4JXNnmgHbLKo5FcnSnjs889VGAWXSXMn1J5X01G2mBiN5RqZEn+Lnv1IixJEn UJMQ== X-Gm-Message-State: AMCzsaVyBqYuY9X7Ivu/adIhWXjDw2i2yH8iQQllZSB1XlHssTZdgrWR rJqJ+TXb2GUQrRh9lTDANbNHJ4KH131+qbhpJO4= X-Google-Smtp-Source: ABhQp+RTqQrpBEYXMObIwRyuMmaTGqRqGcDcgNYvcwkLJRG11moGUNoWmuroPuc/aAcTW4lZj2BA0FiMJEshp9fJL6A= X-Received: by 10.202.171.216 with SMTP id u207mr906669oie.430.1508425312251; Thu, 19 Oct 2017 08:01:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.168.200 with HTTP; Thu, 19 Oct 2017 08:01:51 -0700 (PDT) In-Reply-To: References: <20160819203022.GA12109@intel.com> From: "H.J. Lu" Date: Sun, 01 Jan 2017 00:00:00 -0000 Message-ID: Subject: Re: [PATCH] X86-64: Correct CFA in _dl_runtime_resolve To: GNU C Library , Libc-stable Mailing List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00035.txt.bz2 On Fri, Aug 26, 2016 at 8:53 AM, H.J. Lu wrote: > On Fri, Aug 19, 2016 at 1:30 PM, H.J. Lu wrote: >> When stack is re-aligned in _dl_runtime_resolve, there is no need to >> adjust CFA when allocating register save area on stack. >> >> Tested on x86-64. OK for master? >> >> >> H.J. >> --- >> * sysdeps/x86_64/dl-trampoline.h (_dl_runtime_resolve): Don't >> adjust CFA when allocating register save area on re-aligned >> stack. >> --- >> sysdeps/x86_64/dl-trampoline.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sysdeps/x86_64/dl-trampoline.h b/sysdeps/x86_64/dl-trampoline.h >> index b90836a..8161f96 100644 >> --- a/sysdeps/x86_64/dl-trampoline.h >> +++ b/sysdeps/x86_64/dl-trampoline.h >> @@ -69,7 +69,9 @@ _dl_runtime_resolve: >> and $-VEC_SIZE, %RSP_LP >> #endif >> sub $REGISTER_SAVE_AREA, %RSP_LP >> +#if !DL_RUNTIME_RESOLVE_REALIGN_STACK >> cfi_adjust_cfa_offset(REGISTER_SAVE_AREA) >> +#endif >> # Preserve registers otherwise clobbered. >> movq %rax, REGISTER_SAVE_RAX(%rsp) >> movq %rcx, REGISTER_SAVE_RCX(%rsp) >> -- >> 2.7.4 >> > > I am checking it in. > I am backporting it to 2.24 and 2.23 branches. -- H.J.