From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 0FAE43858D35; Tue, 1 Feb 2022 19:46:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FAE43858D35 Received: by mail-pj1-x1031.google.com with SMTP id z10-20020a17090acb0a00b001b520826011so4328215pjt.5; Tue, 01 Feb 2022 11:46:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bVSrknPHdZDftIJ7+pfrEP52oh77lc6Ex/kv0lg6R+A=; b=shWjbNeXgpReG4Yx8Oep2+7yZeNzu9r5KWRGorHusReaTu8x2MHSdWJKSMkDxODyKJ Q+h3226IAnbWqbPJsAJq0IjBgn8oK6VHFuoj2nzEeQWjl/8DTOQTVX/BW5PZs0ogs8ss tIF+PrYPYXwQNiIu0IebQV8v4mEAYjxn7zms9Tk6qYi2OtU6vYX8jdWVRblaxVKXmyi6 xTpTT8TEJAk/dOflERvyTZ0bBxucO55MKQHFeVU0Y9IK/wnUR4xDuQfXM6N5R45YYnZL g7WenqyQkF1OsX7gKwcSqske+h0FVCSDsitQG22U8P8ZQr6RRf25vhbOy39wrftOQIlp pg8g== X-Gm-Message-State: AOAM533DZZ75rITl3zjNDyhgsj6BRYKBvfgaL0cbab1W6xEWO28xXrVJ wWhx/f6BdWPOcDZIKvs6qW0UHgQ+yxxDlmrNS5c= X-Google-Smtp-Source: ABdhPJwJF628T9nUWNbH+H+zHMFnoDedSdkrt+V4Y1wDnv2RANFXdnCJBjw6YJrEGplKMMvj9QIKmBnx6GAUffEFgE8= X-Received: by 2002:a17:90b:4f83:: with SMTP id qe3mr4142719pjb.120.1643744778828; Tue, 01 Feb 2022 11:46:18 -0800 (PST) MIME-Version: 1.0 References: <20210708081308.640036-1-goldstein.w.n@gmail.com> <20210708201318.1222367-1-goldstein.w.n@gmail.com> <20210708201318.1222367-2-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 1 Feb 2022 11:45:43 -0800 Message-ID: Subject: Re: [PATCH v2 2/2] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064] To: Noah Goldstein , Libc-stable Mailing List Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 19:46:21 -0000 On Thu, Jul 8, 2021 at 1:30 PM H.J. Lu wrote: > > On Thu, Jul 8, 2021 at 1:14 PM Noah Goldstein wrote: > > > > The following commit > > > > commit 6f573a27b6c8b4236445810a44660612323f5a73 > > Author: Noah Goldstein > > Date: Wed Jun 23 01:19:34 2021 -0400 > > > > x86-64: Add wcslen optimize for sse4.1 > > > > Added wcsnlen-sse4.1 to the wcslen ifunc implementation list and did > > not add wcslen-sse4.1 to wcslen ifunc implementation list. This commit > > fixes that by removing wcsnlen-sse4.1 from the wcslen ifunc > > implementation list and adding wcslen-sse4.1 to the ifunc > > implementation list. > > > > Testing: > > test-wcslen.c, test-rsi-wcslen.c, and test-rsi-strlen.c are passing as > > well as all other tests in wcsmbs and string. > > > > Signed-off-by: Noah Goldstein > > Reviewed-by: H.J. Lu > > --- > > Confirmed test-rsi-wcslen.c failed before this fix. > > Great. > > > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > index dbd1ebf298..39ab10613b 100644 > > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > @@ -684,9 +684,9 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > > && CPU_FEATURE_USABLE (AVX512BW) > > && CPU_FEATURE_USABLE (BMI2)), > > __wcslen_evex) > > - IFUNC_IMPL_ADD (array, i, wcsnlen, > > + IFUNC_IMPL_ADD (array, i, wcslen, > > CPU_FEATURE_USABLE (SSE4_1), > > - __wcsnlen_sse4_1) > > + __wcslen_sse4_1) > > IFUNC_IMPL_ADD (array, i, wcslen, 1, __wcslen_sse2)) > > > > /* Support sysdeps/x86_64/multiarch/wcsnlen.c. */ > > -- > > 2.25.1 > > > > LGTM. Please check in both patches. > > Reviewed-by: H.J. Lu > I am backporting this to release branches. -- H.J.