From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>, libc-stable@sourceware.org
Subject: Re: [PATCH v2] elf: Replace nsid with args.nsid [BZ #27609]
Date: Wed, 13 Oct 2021 05:03:09 -0700 [thread overview]
Message-ID: <CAMe9rOq44thrqks3BeAon_oi72qh5Q_+ty3n+JBgeCAxxVLK7A@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOrbsOiH6MKKLkp3uW9_dnLk3rZpN++z0cSLOJ3CJURuCw@mail.gmail.com>
On Thu, Sep 30, 2021 at 11:36 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Sep 30, 2021 at 11:27 AM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * H. J. Lu:
> >
> > > do_dlopen calls _dl_open with nsid == __LM_ID_CALLER (-2), which calls
> > > dl_open_worker with args.nsid = nsid. dl_open_worker updates args.nsid
> > > if it is __LM_ID_CALLER. After dl_open_worker returns, use args.nsid
> > > instead of nsid. This fixes BZ #27609.
> > > ---
> > > elf/dl-open.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/elf/dl-open.c b/elf/dl-open.c
> > > index a25443f6d1..5295e931b0 100644
> > > --- a/elf/dl-open.c
> > > +++ b/elf/dl-open.c
> > > @@ -886,7 +886,7 @@ no more namespaces available for dlmopen()"));
> > > /* Avoid keeping around a dangling reference to the libc.so link
> > > map in case it has been cached in libc_map. */
> > > if (!args.libc_already_loaded)
> > > - GL(dl_ns)[nsid].libc_map = NULL;
> > > + GL(dl_ns)[args.nsid].libc_map = NULL;
> > >
> > > /* Remove the object from memory. It may be in an inconsistent
> > > state if relocation failed, for example. */
> >
> > Patch looks okay. But could you reference the fixed commit in the
> > commit message?
> >
>
> Done. Here is the patch I am checking in.
>
> Thanks.
>
> --
> H.J.
I am backporting it to release branches.
--
H.J.
parent reply other threads:[~2021-10-13 12:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAMe9rOrbsOiH6MKKLkp3uW9_dnLk3rZpN++z0cSLOJ3CJURuCw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOq44thrqks3BeAon_oi72qh5Q_+ty3n+JBgeCAxxVLK7A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).