From: "H.J. Lu" <hjl.tools@gmail.com>
To: Libc-stable Mailing List <libc-stable@sourceware.org>
Subject: Fwd: [PATCH] i386: Use _dl_runtime_[resolve|profile]_shstk for SHSTK [BZ #23716]
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <CAMe9rOqEO9MN693Fzvfdf=27k2kEVeb+zdK0m15rGAjV+svt2Q@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOrQtgJDzCnmZgigXrQCqxrZ0-xOZ0END_o-owM8KcuRZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
I will backport this to glibc 2.28 branch next week.
H.J.
---------- Forwarded message ---------
From: H.J. Lu <hjl.tools@gmail.com>
Date: Fri, Sep 28, 2018 at 1:25 PM
Subject: Re: [PATCH] i386: Use _dl_runtime_[resolve|profile]_shstk for
SHSTK [BZ #23716]
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
On Fri, Sep 28, 2018 at 7:33 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Sep 26, 2018 at 10:30 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Sep 26, 2018 at 10:23 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> * H. J. Lu:
>>>
>>>> diff --git a/sysdeps/i386/dl-trampoline.S b/sysdeps/i386/dl-trampoline.S
>>>> index 6dc0319216..9734f9c981 100644
>>>> --- a/sysdeps/i386/dl-trampoline.S
>>>> +++ b/sysdeps/i386/dl-trampoline.S
>>>> @@ -33,6 +33,7 @@
>>>> _dl_runtime_resolve:
>>>> cfi_adjust_cfa_offset (8)
>>>> _CET_ENDBR
>>>> + hlt
>>>> pushl %eax # Preserve registers otherwise clobbered.
>>>> cfi_adjust_cfa_offset (4)
>>>> pushl %ecx
>>>
>>> That doesn't look right. 8-)
>>>
>>
>> This is the change I used to test my fix to verify that the SHSTK resolver
>> is used if SHSTK is enabled by kernel. It isn't the part of the fix.
>>
>
> We verified that the fix worked on CET simulator. If there is no objection,
> I will check it later today.
>
> Thanks.
This is the patch I am checking in now.
--
H.J.
--
H.J.
[-- Attachment #2: 0001-i386-Use-_dl_runtime_-resolve-profile-_shstk-for-SHS.patch --]
[-- Type: application/x-patch, Size: 5259 bytes --]
parent reply other threads:[~2018-10-05 13:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAMe9rOrQtgJDzCnmZgigXrQCqxrZ0-xOZ0END_o-owM8KcuRZQ@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqEO9MN693Fzvfdf=27k2kEVeb+zdK0m15rGAjV+svt2Q@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).