From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by sourceware.org (Postfix) with ESMTPS id C733D3858430 for ; Thu, 9 May 2024 21:47:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C733D3858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C733D3858430 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715291246; cv=none; b=r/UIYkBbA0U3IPGqF0jvTwsNPF/qNiOdlbpk+SIRN0gI+e6VL85iNe6Sfik+Cu6YSGp5we+F7gy3Ej4cPxGuQtQgXS7DGE0J3okF9B2dX1kFJj8ssTfIELaaP1xT620CxAlY2+W4bZpICzKqf69K02xL6rS7cr0rtyFRmWREpP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715291246; c=relaxed/simple; bh=L76oB6ogFgd2COBfa4+zkhFRZxXQGpyMFS3jQr9Aujs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Jb5g6/iMUuetqqzrCOYPnDhZOZK6XxvwCfKPd237fEpa/4nobxbPwvyovbJRUzMDUnKUQrTSvPC/1KAzLsw0d4n2Y4jpNKQ16ocH1i20LVKkhf4SjeWRf5CnJEXvBlFS9D7S9pph0LJRIzYlz/eb2yPQq0cjHyG2PciQVzu6O1I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-deb65b541faso1460215276.0 for ; Thu, 09 May 2024 14:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715291244; x=1715896044; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+ZNJknVMDbUVyOPLzzPjbtTu9sjf3fu+fyKfNRuvs0A=; b=bFeNk6iNrPqbB98Pi/zbWitcWQ4N3o+ChhMcF4PQozucM6wkkJUa7D/x09ZTCHlc0t oUEBFsPp8Pn6D0ZFWT5o5xynCT5d3h0y28kT2B1gqqNWQQqq8+r4NNkJpvM/8xLK1N85 d2rFXjlV6P1kAe1ArbqzJloDqswv9L3aQiL/k9ziR2OlpxoMBfdP+F+vdScWcOqp46zq h7wyJyLmvqahQLMW6Q6klBchRG396HYZ1W+ZVhg97qNhPbIba3zOoqqqgYEn6g5mSlvb 8F6IWx8MIp+iia7Hg0uNRm3dm/5j49r5OtD9bmoIGyvLKVoHOh11HAeK9XvrI8r7YIQK NaHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715291244; x=1715896044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ZNJknVMDbUVyOPLzzPjbtTu9sjf3fu+fyKfNRuvs0A=; b=B8WkQnux8UVspWjXBVyFNW5g6tZo4vDqrm3zegkvZ5hUI9sVmrO1+d6D2cip0V306M mkUGGM14jLqgrvJPetu9JfcTDIIb7/6v5aUFEHu0rF2dIRbJc16iwqhrQMzEZXSfJ6e1 AziUAP/1KvNu8CJmXJoL3eAY43cgrOfFZzXC45FW0ASjewOMkmWRpIMqZHFKnuNJfsSS IAZ86oK+/D+irN9j4GffepTJkBxZaKmcLmpVhdVTNeeev1CaTsTMXQU2Lj151MeNk0Sn Io5FB64UGnAVWEp6igwEevghwbP5Kx+/27K0vRhb/V41Mos1zrzQNUILEbKHLlI3zhHW TRaQ== X-Gm-Message-State: AOJu0YxWnL+is47NEmoqSwGD5opZicroU6uBAZOWTa6aPTAvrESiVOmo VTAjwuEdQUNbt0SiklewifNQD7Q72uCCDxGDpnQcd3sq7H2YyiJoJCweyiM1feRVHsTjD3xN2nI 6v3ZSFI2aferLLJRa5/5JPcCU/2TLIw== X-Google-Smtp-Source: AGHT+IGBUQhlmAE4eb7uIeCfV6oivzJ7/Zs21BDtT9OPK8g46TVSGGges+y5dKRc2jYLb8f6KVfyViMg4T63y5mlsig= X-Received: by 2002:a25:204:0:b0:de6:1083:1fc0 with SMTP id 3f1490d57ef6-dee4f368fa0mr804396276.33.1715291244105; Thu, 09 May 2024 14:47:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Thu, 9 May 2024 14:46:48 -0700 Message-ID: Subject: Re: [Backport] testsuite: stdlib/isomac.c: add missing include To: Sunil Pandey Cc: Libc-stable Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 9, 2024 at 2:45=E2=80=AFPM Sunil Pandey wro= te: > > I would like to backport following commit to 2.29 and 2.28 branches. Any= comments or objections? > > commit 11f382ee780649549428cb25af3a9f1d3465868d > Author: Aurelien Jarno > Date: Tue Jan 8 21:10:28 2019 +0100 > > testsuite: stdlib/isomac.c: add missing include > > When running the testsuite, building stdlib/isomac.c outputs the > following warning: > > gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-b= uild/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac > isomac.c: In function ?get_null_defines?: > isomac.c:260:3: warning: implicit declaration of function ?close?; = did you mean ?pclose?? [-Wimplicit-function-declaration] > close (fd); > ^~~~~ > pclose > > Fix that by adding the include. > > Changelog: > * stdlib/isomac.c: Include . LGTM. Reviewed-by: H.J. Lu Thanks. --=20 H.J.