From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fw@deneb.enyo.de>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] test-strnlen.c: Check that strnlen won't go beyond the maximum length
Date: Thu, 27 Jan 2022 09:09:14 -0800 [thread overview]
Message-ID: <CAMe9rOqf-iKEbKDu9-7R2acj17bZ3o7YaNaAO=8XV+g=GJzQSA@mail.gmail.com> (raw)
In-Reply-To: <871rc08mym.fsf@mid.deneb.enyo.de>
On Sat, Mar 27, 2021 at 11:34 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > From: "H.J. Lu" <hjl.tools@gmail.com>
> > Date: Sat, 27 Mar 2021 09:06:39 -0700
> > Subject: [PATCH v2] test-strnlen.c: Check that strnlen won't go beyond the
> > maximum length
> >
> > Place strings ending at page boundary without the null byte. If an
> > implementation goes beyond EXP_LEN, it will trigger the segfault.
> > ---
> > string/test-strnlen.c | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> > index 0293acbc71..d70faa26ab 100644
> > --- a/string/test-strnlen.c
> > +++ b/string/test-strnlen.c
> > @@ -198,6 +198,35 @@ do_page_tests (void)
> > }
> > }
> >
> > +/* Tests meant to unveil fail on implementations that access bytes
> > + beyond the maxium length. */
> > +
> > +static void
> > +do_page_2_tests (void)
> > +{
> > + size_t i, exp_len, offset;
> > + size_t last_offset = page_size / sizeof (CHAR);
> > +
> > + CHAR *s = (CHAR *) buf2;
> > + MEMSET (s, 65, last_offset);
> > +
> > + /* Place short strings ending at page boundary without the null
> > + byte. */
> > + offset = last_offset;
> > + for (i = 0; i < 128; i++)
> > + {
> > + /* Decrease offset to stress several sizes and alignments. */
> > + offset--;
> > + exp_len = last_offset - offset;
> > + FOR_EACH_IMPL (impl, 0)
> > + {
> > + /* If an implementation goes beyond EXP_LEN, it will trigger
> > + the segfault. */
> > + do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len);
> > + }
> > + }
> > +}
>
> Thanks, looks good. The comments and the commit message are much
> clearer now.
I am backporting this to release branches.
--
H.J.
parent reply other threads:[~2022-01-27 17:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <871rc08mym.fsf@mid.deneb.enyo.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqf-iKEbKDu9-7R2acj17bZ3o7YaNaAO=8XV+g=GJzQSA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).