From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 406723858D20; Thu, 25 Apr 2024 15:12:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 406723858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 406723858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057951; cv=none; b=WfHlqMVitGrYGCr/ZqiCdkQAH4ALCafoPmzIODFqt1vAy+j3B+mF5p9OFrmRyHgmbcEBSjgyQDvoZZVJRTLdBCNbmBSrqe5Sbb+rmzS7FO5VaviOB6Wtox1KmAp30q3zIMplUV1KOBT6VXnzh9dENnaE+Sbbx1DIE0r0GThbcCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057951; c=relaxed/simple; bh=724lRWiaAhnkg1mPLSRxyarifl3CcEXIzr3B5RrZIUs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=PrHHJ+JoLAQEmAADpRnYuR8zPBRSF9AMpk3nG4wg1vblIr79sO6KhggEt4z/yZwLPnzTvMDKPV0jMWvqiv1JTnXuVLRB0InIWP90mz3vU/f/o79NWn93V5Q7kXeJFOP1H4WOaKZNPKn2b7Z7PENp2QLw7kPnW4Np3TMDtf6cqV4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-de45dba157cso1094366276.3; Thu, 25 Apr 2024 08:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714057948; x=1714662748; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ryzN3dC49R21znQMw0okkwj0g70nayMP4KaJF8IaBuE=; b=NiPDYrOjJrJKaU0kV+OX4vOcHZpOeGbs6BMoWL5uW9f542YmtN6FBXgHt3z4LmW0KI H50JcIYf8INgoSPHlfaKXxu8u2XnrgrB5Hf3NAwZtBisME1/onSg/AXpCt4ZdJZWldfP 5bKQgwBuDWpgNO/S8GpQM6NJy4XdAqeuSt61DNxUFsGZG6fuGFovNFNoCBb/OlUlxvKW yBwsmX0KcXm/RSMlON+dLYdUI8At5EBICazzSVvX30eW/nYBrc/C/Z0rBYcTxQFmgTRd 6tjklQJLS551O94rRdEOXUEEZiwNuDKfB/yd2x8p+9VuAJ/A6cQKyqr4muX0tybrHRzR yN8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057948; x=1714662748; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ryzN3dC49R21znQMw0okkwj0g70nayMP4KaJF8IaBuE=; b=BwwAAROW5ZPqSX4AKsx87n3iYHg4xaCw+RfEjBRXP471JCDXNBRscqfNuMD6DrZ2iI lY8g9N8wQvHgGWP/3A+1IGZxcFCeC/e2OqqbKztJjnAYkbDh+Q+6qJ+VCkZbHLXisEPT 3H8vN62IgqsiDUaMO3XbOukxeYHIHccYgg6ZmcCUDp+kJ4SA1r05xT8wg2ZKK0DMhYHh g/RxNbn2A8YlEzy8y9MT9WG3K6vJxcP18cQ1+Q0J/rtOGbB8X2jbTGznwA5HSVirCg0E WD7FfoBNj80r1qTzOZk3I18rNXKGK/dD9U/YGL9tO0mOAnyCXEwXKpdgwERT2m8CGBiK j37Q== X-Forwarded-Encrypted: i=1; AJvYcCWFmQEHP6V4jZ16ZFgYDg7tvt6MwBxfiQsif8DOlO/G8Pp9J7MLf2SRXkS0/0vKkLDEG2kObaYpA4lUSIu+iPAZsNp90TV8yv3yCg== X-Gm-Message-State: AOJu0YyxJVn4MEokne92iRwQ23/7RjYNcYn6aKHUnlYbAza9WInWBpsO jWhU+ZYvXqcmmMG8sKk+vhA8Jul/yagVQywDV8R4xIow8g9I6xTzFTTIP48yYoT43JxPodxxq6K OursLZeHp379C2OTk+Cy5xXY/Dy8= X-Google-Smtp-Source: AGHT+IHVp7QdFiMZNBTnTSHeHjOGXdfZIItzKBl1wR/GDwGvyOtOGot6rlxpoyOb0Mpnk6T4/q+DkxFrY6RgsSFCi/0= X-Received: by 2002:a25:248:0:b0:de4:8b7:7bbd with SMTP id 69-20020a250248000000b00de408b77bbdmr6290158ybc.15.1714057948316; Thu, 25 Apr 2024 08:12:28 -0700 (PDT) MIME-Version: 1.0 References: <20240425150652.309939-1-hjl.tools@gmail.com> <87sez94h04.fsf@oldenburg.str.redhat.com> In-Reply-To: <87sez94h04.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Thu, 25 Apr 2024 08:11:52 -0700 Message-ID: Subject: Re: [PATCH v3] elf: Also compile dl-misc.os with $(rtld-early-cflags) To: Florian Weimer , Libc-stable Mailing List Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3012.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 25, 2024 at 8:08=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > Also compile dl-misc.os with $(rtld-early-cflags) to avoid > > > > Program received signal SIGILL, Illegal instruction. > > 0x00007ffff7fd36ea in _dl_strtoul (nptr=3Dnptr@entry=3D0x7fffffffe2c9 "= 2", > > endptr=3Dendptr@entry=3D0x7fffffffd728) at dl-misc.c:156 > > 156 bool positive =3D true; > > (gdb) bt > > #0 0x00007ffff7fd36ea in _dl_strtoul (nptr=3Dnptr@entry=3D0x7fffffffe= 2c9 "2", > > endptr=3Dendptr@entry=3D0x7fffffffd728) at dl-misc.c:156 > > #1 0x00007ffff7fdb1a9 in tunable_initialize ( > > cur=3Dcur@entry=3D0x7ffff7ffbc00 , > > strval=3Dstrval@entry=3D0x7fffffffe2c9 "2", len=3Dlen@entry=3D1) > > at dl-tunables.c:131 > > #2 0x00007ffff7fdb3a2 in parse_tunables (valstring=3D) > > at dl-tunables.c:258 > > #3 0x00007ffff7fdb5d9 in __GI___tunables_init (envp=3D0x7fffffffdd58) > > at dl-tunables.c:288 > > #4 0x00007ffff7fe44c3 in _dl_sysdep_start ( > > start_argptr=3Dstart_argptr@entry=3D0x7fffffffdcb0, > > dl_main=3Ddl_main@entry=3D0x7ffff7fe5f80 ) > > at ../sysdeps/unix/sysv/linux/dl-sysdep.c:110 > > #5 0x00007ffff7fe5cae in _dl_start_final (arg=3D0x7fffffffdcb0) at rt= ld.c:494 > > #6 _dl_start (arg=3D0x7fffffffdcb0) at rtld.c:581 > > #7 0x00007ffff7fe4b38 in _start () > > (gdb) > > > > when setting GLIBC_TUNABLES in glibc compiled with APX. > > Looks good. > > Reviewed-by: Florian Weimer > > Thanks, > Florian > I'd like to backport it to release branches. --=20 H.J.