public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-stable@sourceware.org
Subject: Backport /dev/pts to older branches?
Date: Fri, 19 Aug 2022 11:39:12 +0200	[thread overview]
Message-ID: <Yv9aQBaulhUfcMep@aurel32.net> (raw)

Dear all,

I would be interested in backporting the following change to Debian
Bullseye package:

commit 27fe5f2e67a0e4cc0526b1b32b55f8e519075edb
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed Oct 7 14:55:04 2020 +0200

    Linux: Require properly configured /dev/pts for PTYs

    Current systems do not have BSD terminals, so the fallback code in
    posix_openpt/getpt does not do anything.  Also remove the file system
    check for /dev/pts.  Current systems always have a devpts file system
    mounted there if /dev/ptmx exists.

    grantpt is now essentially a no-op.  It only verifies that the
    argument is a ptmx-descriptor.  Therefore, this change indirectly
    addresses bug 24941.

    Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

This fixes bz#24941, which seems to affects ansible users. I wonder if I
should backport it in the upstream stable release branch instead. This
is trivial to backport, but on some rare systems, this might require some
changes to get /dev/pts working.

Any thought about that?

Thanks
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

             reply	other threads:[~2022-08-19  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  9:39 Aurelien Jarno [this message]
2022-08-19 11:18 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv9aQBaulhUfcMep@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=libc-stable@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).