From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70273 invoked by alias); 7 Feb 2019 20:32:10 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 70259 invoked by uid 89); 7 Feb 2019 20:32:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-qt1-f195.google.com Received: from mail-qt1-f195.google.com (HELO mail-qt1-f195.google.com) (209.85.160.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Feb 2019 20:32:09 +0000 Received: by mail-qt1-f195.google.com with SMTP id b8so1500387qtj.1 for ; Thu, 07 Feb 2019 12:32:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xctu51w3yYZ+HkOeOs+W4V7bZF/wFQ8huo8EMupdyz8=; b=MyxkKCaNVeLxeA1YrDBQOXDV1hh8/ioP9l7cyCdkAG4ra3zk7FDZ51e5EDGA/p11qS RZOVfGj+CLcUeIoJpt0jHcTIjzUEmmYRS5Bf57xyGhCwQvCHyfj87MMC/TRu/Dy4WBpj zGCihCdckiQXsihLE4B0QY9B1ADrRPKPtd+JW2R55QQWmXVibKNtHsN3rvSBI2LnMGt1 f7wEax32smeAm440zlz4RukSC3AnbSCCZDbIkbkqISpefDXR7UXIHUxBsXDihknzBtgg kjBup840OfEjFfo5gjE8MeZIISioyJq3iaL/iRbx4UKUV2krDP52YYovkG3Ok/frKGOS xpAg== X-Gm-Message-State: AHQUAuYzJQ3H8m3dbfkBGN+0ITRl0tdrWz+WArtGI/BkWZDCHz2pD9Sj Mgjyz56uPucqkZw0/JN4fp/62w== X-Google-Smtp-Source: AHgI3IZryqal3DAWhmT2OMxIv/Gcv2lbo8lrtOfAzzg5NYUwcl9688cxZidamJ3SP45+Cmi7xrO4kQ== X-Received: by 2002:a0c:aee1:: with SMTP id n33mr13465435qvd.169.1549571527448; Thu, 07 Feb 2019 12:32:07 -0800 (PST) Received: from [10.150.73.190] (198.sub-174-228-7.myvzw.com. [174.228.7.198]) by smtp.gmail.com with ESMTPSA id 10sm12708613qtx.60.2019.02.07.12.32.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 12:32:06 -0800 (PST) Subject: Re: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] To: Stefan Liebler , GNU C Library , libc-stable@sourceware.org Cc: Thomas Gleixner , Sebastian Sewior , Heiko Carstens , Torvald Riegel , Florian Weimer References: <60ff0bf2-38f9-92b4-7582-8b65c2acfa0e@redhat.com> <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com> From: Carlos O'Donell Openpgp: preference=signencrypt Organization: Red Hat Message-ID: Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SW-Source: 2019-02/txt/msg00022.txt.bz2 On 2/7/19 10:05 AM, Stefan Liebler wrote: > On 02/06/2019 04:59 PM, Carlos O'Donell wrote: >> On 2/6/19 6:25 AM, Stefan Liebler wrote: >>> Hi Carlos, >>> I've updated the patch with three additional comments and I've mentioned the filed bug. >>> Please review it once again before I commit it to master and cherry pick it to the release branches. >> >> Thank you! Reviewed. > Committed to master (2.29.9000): > "Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]" > (https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708) > > and backported it to glibc 2.25 ... 2.29 release branches. Thank you! Now if only we could fix the final robust mutex design flaw[1] ;-) -- Cheers, Carlos. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=14485