public inbox for
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <>
Subject: Re: [committed 2.35] fortify: Ensure that __glibc_fortify condition is a constant [BZ #29141]
Date: Mon, 16 May 2022 22:08:21 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 16/05/2022 21:40, Siddhesh Poyarekar via Libc-stable wrote:
> The fix c8ee1c85 introduced a -1 check for object size without also
> checking that object size is a constant.  Because of this, the tree
> optimizer passes in gcc fail to fold away one of the branches in
> __glibc_fortify and trips on a spurious Wstringop-overflow.  The warning
> itself is incorrect and the branch does go away eventually in DCE in the
> rtl passes in gcc, but the constant check is a helpful hint to simplify
> code early, so add it in.
> Resolves: BZ #29141
> Signed-off-by: Siddhesh Poyarekar <>

Ugh, I'm so sorry, I forgot to use -x :(

We should have a commit hook that rejects patches on release branches 
without the "cherry picked from".


      reply	other threads:[~2022-05-16 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 16:10 Siddhesh Poyarekar
2022-05-16 16:38 ` Siddhesh Poyarekar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).