From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gecko.ash.relay.mailchannels.net (gecko.ash.relay.mailchannels.net [23.83.222.66]) by sourceware.org (Postfix) with ESMTPS id ED0453858D3C for ; Mon, 16 May 2022 16:38:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED0453858D3C X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7654612298C for ; Mon, 16 May 2022 16:38:28 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1FFA712287A for ; Mon, 16 May 2022 16:38:28 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1652719108; a=rsa-sha256; cv=none; b=GkZDaKRFBtSxnnySC7y9asFJts1c4ZHwAg4v3q8kK4VOi3AkoEMA/nHcj2JpvdRPpWaoQc ve3+gCKbl52ueQ+VYjagP0hIGvScsBKSUz3vTaN2rspV5xeaPY0Qagl/q+KRg6m9M1zR5Z F38+rTaOJ32uQ0EaW29MvOJvk1FWhxIptRGrg3LoCEbyAJc49b1pAy/BM672e0A02okmOj BMEIHvaZpKKdbXWjjycYTk2RKrDBVVWwFE2GlhvuYukTA9+1gIsmSO1q28y/6Bm0RlQNje wkKESI6p7309XbNKwGkhbNAZVDSLrEOOfTSSievTMbWizTJ6GhucX4agh3vvbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1652719108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtMCKqufETsBdExOthHLdutX0lM9DNwGNk3zqieCwAU=; b=c26TKhVbajxTePLFjsg7snFxnl8+e6ciPeqxkpglMjn+HCZQWve0shd7rwKyyAYm7/MlmE f1iSDVgfkEeHf1xjyBBTUiET9DrzNDADi9S6iStkQ+r2hcFKe8MVnFaYOELYEw/XerSyuR P1ERy8PcAGq0eQyq0WcnTNo5z/kIlB3ko7src+/b8BgSTK/QC/lHgoLbn/qROHTh7zSvXT vtmyPDWcED+UyMkMKMpPle9Lq5nmlxIKRnsy9kUrWSYsgWUxwkBPuqnZZEoHF6I+3JKtll 4YhsnCQAtUJrbRLsPchkMA9FUiD2yXVIvQdbQ/2v4+3pcjs1y7HifYox9IiDjg== ARC-Authentication-Results: i=1; rspamd-6fcfc4d76-nhs9g; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Blushing-Ruddy: 401ff9676e41c08a_1652719108371_3869714140 X-MC-Loop-Signature: 1652719108371:2103234267 X-MC-Ingress-Time: 1652719108371 Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.105.211.140 (trex/6.7.1); Mon, 16 May 2022 16:38:28 +0000 Received: from [192.168.1.174] (unknown [1.186.223.88]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4L24gk6Hl9z1Wq for ; Mon, 16 May 2022 09:38:26 -0700 (PDT) Message-ID: Date: Mon, 16 May 2022 22:08:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [committed 2.35] fortify: Ensure that __glibc_fortify condition is a constant [BZ #29141] Content-Language: en-US To: libc-stable@sourceware.org References: <20220516161035.1011515-1-siddhesh@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: <20220516161035.1011515-1-siddhesh@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 16:38:34 -0000 On 16/05/2022 21:40, Siddhesh Poyarekar via Libc-stable wrote: > The fix c8ee1c85 introduced a -1 check for object size without also > checking that object size is a constant. Because of this, the tree > optimizer passes in gcc fail to fold away one of the branches in > __glibc_fortify and trips on a spurious Wstringop-overflow. The warning > itself is incorrect and the branch does go away eventually in DCE in the > rtl passes in gcc, but the constant check is a helpful hint to simplify > code early, so add it in. > > Resolves: BZ #29141 > Signed-off-by: Siddhesh Poyarekar Ugh, I'm so sorry, I forgot to use -x :( We should have a commit hook that rejects patches on release branches without the "cherry picked from". Siddhesh