From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73883 invoked by alias); 7 Feb 2019 15:05:30 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 73868 invoked by uid 89); 7 Feb 2019 15:05:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=unavailable version=3.3.2 spammy= X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=unavailable version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Feb 2019 15:05:28 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x17F12UW131302 for ; Thu, 7 Feb 2019 10:05:27 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qgpa1jgct-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Feb 2019 10:05:24 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Feb 2019 15:05:08 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 7 Feb 2019 15:05:04 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x17F53Ps55378134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Feb 2019 15:05:03 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73EC652078; Thu, 7 Feb 2019 15:05:03 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.152.222.58]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id E84AB5207B; Thu, 7 Feb 2019 15:05:02 +0000 (GMT) Subject: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] To: GNU C Library , libc-stable@sourceware.org Cc: "Carlos O'Donell" , Thomas Gleixner , Sebastian Sewior , Heiko Carstens , Torvald Riegel , Florian Weimer References: <60ff0bf2-38f9-92b4-7582-8b65c2acfa0e@redhat.com> <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com> From: Stefan Liebler Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-IE Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19020715-0012-0000-0000-000002F2EEFA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19020715-0013-0000-0000-0000212A54C2 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-07_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902070116 X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00021.txt.bz2 On 02/06/2019 04:59 PM, Carlos O'Donell wrote: > On 2/6/19 6:25 AM, Stefan Liebler wrote: >> Hi Carlos, >> I've updated the patch with three additional comments and I've mentioned the filed bug. >> Please review it once again before I commit it to master and cherry pick it to the release branches. > > Thank you! Reviewed. Committed to master (2.29.9000): "Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]" (https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708) and backported it to glibc 2.25 ... 2.29 release branches. Thanks. Stefan > >>> Yes, I did that backport to RHEL 7.6. These fixes are just "further" >>> fixes right? I'll work on getting this fixed in RHEL 7.7, and RHEL 8 >>> for all arches. >> Sounds great. >> That's the same fix for pthread_mutex_trylock as previously done for pthread_mutex_lock and pthread_mutex_timedlock. > > I've filed these: > https://bugzilla.redhat.com/show_bug.cgi?id=1672771 > https://bugzilla.redhat.com/show_bug.cgi?id=1672773 > > Feel free to comment or verify if they are going to be needed in RHEL7.7 > or RHEL8. I haven't done the analysis of the disassembly yet. If you > could have a look that would help. >