From: Andrew Bennett <Andrew.Bennett@imgtec.com>
To: "libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Subject: [PATCH] MIPS: Do not force the n32.S file to be assembled as MIPS4
Date: Fri, 28 Aug 2015 13:01:00 -0000 [thread overview]
Message-ID: <0DA23CC379F5F945ACB41CF394B982772111344D@LEMAIL01.le.imgtec.org> (raw)
Hi,
The n32.S file in the MIPS backend currently is forced to be compiled as MIPS4.
This could lead to the wrong instruction encodings being used when assembling
for newer MIPS architectures. This patch only forces the .set mips4 constraint
if the MIPS architecture provided by the compiler is older than MIPS4.
The patch and ChangeLog are below.
Regards,
Andrew
* src/mips/n32.S: Only force the file to be assembled as MIPS4 if
the architecture provided by the compiler is older than MIPS4.
diff --git a/src/mips/n32.S b/src/mips/n32.S
index c6985d3..512063a 100644
--- a/src/mips/n32.S
+++ b/src/mips/n32.S
@@ -43,7 +43,9 @@
#ifdef __GNUC__
.abicalls
#endif
+#if __mips < 4
.set mips4
+#endif
.text
.align 2
.globl ffi_call_N32
reply other threads:[~2015-08-28 13:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DA23CC379F5F945ACB41CF394B982772111344D@LEMAIL01.le.imgtec.org \
--to=andrew.bennett@imgtec.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).