From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 6F3C2385DC08 for ; Mon, 6 Apr 2020 17:58:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F3C2385DC08 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-_5d9Qy6SMvWlgryf-W_4GQ-1; Mon, 06 Apr 2020 13:58:09 -0400 X-MC-Unique: _5d9Qy6SMvWlgryf-W_4GQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36E9F18C35A0; Mon, 6 Apr 2020 17:58:08 +0000 (UTC) Received: from ovpn-114-204.phx2.redhat.com (ovpn-114-204.phx2.redhat.com [10.3.114.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id D990A19C58; Mon, 6 Apr 2020 17:58:07 +0000 (UTC) Message-ID: <0ecc64ec31aa62915bbae1b88bdb42934bbdf371.camel@redhat.com> Subject: Re: [PATCH libffi 1/4] Use a template to pass $CC and $CXX to DejaGNU From: Jeff Law Reply-To: law@redhat.com To: "Maciej W. Rozycki" , libffi-discuss@sourceware.org Cc: gcc-patches@gcc.gnu.org Date: Mon, 06 Apr 2020 11:58:07 -0600 In-Reply-To: References: Organization: Red Hat User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libffi-discuss@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libffi-discuss mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 17:58:27 -0000 On Fri, 2020-04-03 at 23:55 +0100, Maciej W. Rozycki via Gcc-patches wrote: > Use an Autoconf template rather an inline piece of scriptery to set > DejaGNU's $CC_FOR_TARGET and $CXX_FOR_TARGET variables from $CC and $CXX > respectively, making it easier to maintain and making it take advantage > of Automake's dependency and rule generation. Relocate the generated > `local.exp' file to within testsuite/ so as to make its regeneration > rule to actually work, i.e. (in testsuite/Makefile.in): > > EXTRA_DEJAGNU_SITE_CONFIG = local.exp > site.exp: Makefile $(EXTRA_DEJAGNU_SITE_CONFIG) > [...] > local.exp: $(top_builddir)/config.status $(srcdir)/local.exp.in > cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@ > > It wouldn't work if the regeneration rule was placed in the top-level > Makefile.in, which is what Automake would faithfully do if `local.exp' > stayed in the top level directory. > --- > Hi, > > I think having individual AC_CONFIG_FILES macro invocations for each > output file or group of files would make this change (and code itself) > more readable, however it hasn't been done before and I decided not to > change the style on this occasion. It may make sense as a follow-up > clean-up. > > Maciej > --- > Makefile.am | 3 --- > configure.ac | 7 +------ > testsuite/Makefile.am | 2 +- > testsuite/local.exp.in | 2 ++ > 4 files changed, 4 insertions(+), 10 deletions(-) So from the cover letter I got the impression this series was supposed to be pulling down some bits from upstream libffi into gcc's copy. But AFAICT that's not the case. I don't see anything inherently wrong here. It was just a bit confusing. It's actually follow-on patches where you're cherry picking from the upstream libffi repository. OK for the trunk. jeff >