From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3170 invoked by alias); 8 Mar 2012 23:14:40 -0000 Received: (qmail 3152 invoked by uid 22791); 8 Mar 2012 23:14:39 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_BF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e38.co.us.ibm.com (HELO e38.co.us.ibm.com) (32.97.110.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 23:14:13 +0000 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Mar 2012 16:14:13 -0700 Received: from d01dlp03.pok.ibm.com (9.56.224.17) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 8 Mar 2012 16:14:11 -0700 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 9E7E4C90057 for ; Thu, 8 Mar 2012 18:14:09 -0500 (EST) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q28NEAH2265612 for ; Thu, 8 Mar 2012 18:14:10 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q28NE9JS031082 for ; Thu, 8 Mar 2012 20:14:09 -0300 Received: from [192.168.1.103] (vorma.rchland.ibm.com [9.10.86.174]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q28NE88r030975; Thu, 8 Mar 2012 20:14:08 -0300 Message-ID: <1331248447.24120.14.camel@otta> Subject: Re: libffi fails to build on powerpc64-linux From: Peter Bergner To: Anthony Green Cc: libffi-discuss@sourceware.org, dclarke@blastwave.org Date: Thu, 08 Mar 2012 23:14:00 -0000 In-Reply-To: <1331048083.21041.17.camel@otta> References: <64185.10.0.66.17.1330988704.squirrel@interact.purplecow.org> <1330990156.29904.24.camel@otta> <1330993709.21041.5.camel@otta> <1331048083.21041.17.camel@otta> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12030823-5518-0000-0000-000002D486AC X-IsSubscribed: yes Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2012/txt/msg00099.txt.bz2 On Tue, 2012-03-06 at 09:34 -0600, Peter Bergner wrote: > On Mon, 2012-03-05 at 22:18 -0500, Anthony Green wrote: > > At this point, I'm hoping that Kyle Moffett, the author of this patch > > can have a look. My guess is that either I mis-applied the patch, or > > he posted the wrong patch to apply. > > Agreed, it would be nice for Kyle to comment. Looking at the bugzilla > above, he said: > > > This passes the testsuite on soft-floating-point PowerPC, and it builds > > and passes the testsuite on PowerPC e500 systems which cannot even > > assemble the regular floating-point instruction set. > > Both of these are non FP power systems, so I can see why he didn't > see these build errors, since the broken code is inside of > "#ifndef __NO_FPRS__" (double negative?). Looking at the bugzilla further, I noticed Kyle has a blog here that mentions he has moved to Google, so that explains why his email address was bouncing. I'm also guessing he's no longer interested in PowerPC issues now that he's no longer at Boeing. That said, looking farther down that debian bugzilla, I noticed someone complained about his patch breaking the debian build. He attached a patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=40;filename=libffi-powerpc-build-fix.patch;att=1;bug=644338 If you ignore the debian specific changes and look at the src/powerpc/ffi.c change, you'll see it's the same as my patch, minus the hunks of my patch that are silencing warnings, so I think my patch is probably safe to take as is. Therefore, I'm officially submitting the patch below to fix the build issues. That still leaves the 32-bit many.c testsuite breakage I am seeing, but I think that should be fixed in a separate patch since it is not related to these changes at all. Peter * src/powerpc/ffi.c (ffi_prep_args_SYSV): Declare double_tmp. Silence casting pointer to integer of different size warning. (ffi_call): Silence possibly undefined warning. (ffi_closure_helper_SYSV): Declare variable type. diff --git a/src/powerpc/ffi.c b/src/powerpc/ffi.c index 1920c91..baca694 100644 --- a/src/powerpc/ffi.c +++ b/src/powerpc/ffi.c @@ -146,6 +146,7 @@ ffi_prep_args_SYSV (extended_cif *ecif, unsigned *const stack) gpr_base.u = stacktop.u - ASM_NEEDS_REGISTERS - NUM_GPR_ARG_REGISTERS; intarg_count = 0; #ifndef __NO_FPRS__ + double double_tmp; fpr_base.d = gpr_base.d - NUM_FPR_ARG_REGISTERS; fparg_count = 0; copy_space.c = ((flags & FLAG_FP_ARGUMENTS) ? fpr_base.c : gpr_base.c); @@ -155,9 +156,9 @@ ffi_prep_args_SYSV (extended_cif *ecif, unsigned *const stack) next_arg.u = stack + 2; /* Check that everything starts aligned properly. */ - FFI_ASSERT (((unsigned) (char *) stack & 0xF) == 0); - FFI_ASSERT (((unsigned) copy_space.c & 0xF) == 0); - FFI_ASSERT (((unsigned) stacktop.c & 0xF) == 0); + FFI_ASSERT (((unsigned long) (char *) stack & 0xF) == 0); + FFI_ASSERT (((unsigned long) copy_space.c & 0xF) == 0); + FFI_ASSERT (((unsigned long) stacktop.c & 0xF) == 0); FFI_ASSERT ((bytes & 0xF) == 0); FFI_ASSERT (copy_space.c >= next_arg.c); @@ -211,8 +212,6 @@ ffi_prep_args_SYSV (extended_cif *ecif, unsigned *const stack) case FFI_TYPE_DOUBLE: /* With FFI_LINUX_SOFT_FLOAT doubles are handled like UINT64. */ - if (ecif->cif->abi == FFI_LINUX_SOFT_FLOAT) - goto soft_double_prep; double_tmp = **p_argv.d; if (fparg_count >= NUM_FPR_ARG_REGISTERS) @@ -925,7 +924,7 @@ ffi_call(ffi_cif *cif, void (*fn)(void), void *rvalue, void **avalue) */ unsigned int smst_buffer[2]; extended_cif ecif; - unsigned int rsize; + unsigned int rsize = 0; ecif.cif = cif; ecif.avalue = avalue; @@ -1132,7 +1131,7 @@ ffi_closure_helper_SYSV (ffi_closure *closure, void *rvalue, if (nf < 8) { - temp = pfr->d; + double temp = pfr->d; pfr->f = (float) temp; avalue[i] = pfr; nf++;