From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70514 invoked by alias); 3 Feb 2016 21:39:37 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 70501 invoked by uid 89); 3 Feb 2016 21:39:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=submissions, HTo:U*libffi-discuss X-HELO: mail-pf0-f178.google.com Received: from mail-pf0-f178.google.com (HELO mail-pf0-f178.google.com) (209.85.192.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 03 Feb 2016 21:39:35 +0000 Received: by mail-pf0-f178.google.com with SMTP id 65so20357579pfd.2 for ; Wed, 03 Feb 2016 13:39:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cVSOzgeF1jqPHmfZbHargWtikWtDbj4eYBox9eriyUo=; b=CUdQ9pRi/LhpkVOTYcGBHrLWrFhQB1XbxD11ul9rt8RaRAaNo32HbXGgoPKrfKtF3O 2anEKs03vyDXYT3E0MqGRZLNWrW5buCRUZHY9Vk6sleaY8Zm1mVN+IsSZ9IFNdKvqaok ujDa1f3ntJzNaRhGuas1prmyCmZuxu4q58wnybK/apRARM2w9kTu7jc/SlyKeb9sXyHA BOzAtO8hBeGEBCDRIEOGBnWo4ghuRUffHg/Wl/cV7NmeLuK3ztw869CkPWczArpix/oA mKxcpCjQqsSSgQsoxbEAmB5BKWzNtNtuLIj83MqWwgGjWhVKlxMcArk2va6fUvGenWd/ z6RA== X-Gm-Message-State: AG10YOQW5vpyC07xjdnE9bY3emRoolm+0rghbcGU/DwYGJaAnFGXCbqhNbWOtAWPXXQYGWVk X-Received: by 10.98.80.91 with SMTP id e88mr5884284pfb.62.1454535573130; Wed, 03 Feb 2016 13:39:33 -0800 (PST) Received: from montreal.mtv.corp.google.com ([172.22.64.215]) by smtp.gmail.com with ESMTPSA id 76sm11992777pft.44.2016.02.03.13.39.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Feb 2016 13:39:31 -0800 (PST) From: Filipe Brandenburger To: libffi-discuss@sourceware.org Cc: Filipe Brandenburger Subject: [PATCH] Fix dejagnu test support for --tool_opts Date: Wed, 03 Feb 2016 21:39:00 -0000 Message-Id: <1454535567-9589-1-git-send-email-filbranden@google.com> X-IsSubscribed: yes X-SW-Source: 2016/txt/msg00002.txt.bz2 Right now it concatenates it with the existing options and then appends it to that list, fix it to simply append it as is, same as it is done with the other variables. Tested by running the following command which includes gcc options: $ make check RUNTESTFLAGS="--tool_opts '-Werror'" Without this patch, all the tests fail. With it, the test succeed. Inspecting the logs shows that -Werror was indeed used when compiling the test sources. --- Also available as a GitHub PR: https://github.com/atgreen/libffi/pull/205 Re-sending it to this mailing list, in case GitHub PRs are not the best way to push this, and e-mail submissions are preferred. Thanks! Filipe testsuite/lib/libffi.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/lib/libffi.exp b/testsuite/lib/libffi.exp index 1b8b008fe297..0d74627207dc 100644 --- a/testsuite/lib/libffi.exp +++ b/testsuite/lib/libffi.exp @@ -182,7 +182,7 @@ proc libffi_target_compile { source dest type options } { # TOOL_OPTIONS must come first, so that it doesn't override testcase # specific options. if [info exists TOOL_OPTIONS] { - lappend options [concat "additional_flags=$TOOL_OPTIONS" $options]; + lappend options "additional_flags=$TOOL_OPTIONS" } # search for ffi_mips.h in srcdir, too -- 2.7.0.rc3.207.g0ac5344