From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <madvenka@linux.microsoft.com>
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by sourceware.org (Postfix) with ESMTP id DD387385783E
 for <libffi-discuss@sourceware.org>; Sun,  7 Feb 2021 16:09:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD387385783E
Received: from [192.168.254.32] (unknown [47.187.219.45])
 by linux.microsoft.com (Postfix) with ESMTPSA id B5B6420B6C40;
 Sun,  7 Feb 2021 08:09:45 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B5B6420B6C40
Subject: Re: [RFC PATCH v3 0/5] Libffi Static Trampolines
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
To: Anthony Green <green@moxielogic.com>
Cc: libffi-discuss <libffi-discuss@sourceware.org>, fweimer@redhat.com,
 DJ Delorie <dj@redhat.com>
References: <20210115184653.124913-1-madvenka@linux.microsoft.com>
 <CACxje5-zmPysuo6yPskbXXCxQoe-gF6j0oSxfXOg3zZZNRp+tQ@mail.gmail.com>
 <849643ba-5c3e-31e6-b784-d0fc2345ce00@linux.microsoft.com>
 <CACxje5_WshA6Zi6pBjeCFChfw5zFr+kS763aX0Te5SC2_WFmtw@mail.gmail.com>
 <811113c4-7bda-ee21-cdb9-4ab20d1fd291@linux.microsoft.com>
 <CACxje5-bD3jJQK8kX91=zuGdbaFAHSQaamgnoFPW0dAm7X3CkA@mail.gmail.com>
 <e294e952-09d2-6a32-fe7a-f449df5702b8@linux.microsoft.com>
 <78796ef0-d66b-81e5-d029-5299ff3a4028@linux.microsoft.com>
 <CACxje5_5NrqXrK9GS=cjwNL3Byxy+vsj9BpVZpOzoMCouj_y1Q@mail.gmail.com>
 <07ba7b8f-49b0-d3e9-3c33-69e7e6c9c03b@linux.microsoft.com>
Message-ID: <1a1948ba-1e6d-4845-516c-189a9c1cc004@linux.microsoft.com>
Date: Sun, 7 Feb 2021 10:09:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <07ba7b8f-49b0-d3e9-3c33-69e7e6c9c03b@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-20.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, ENV_AND_HDR_SPF_MATCH, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libffi-discuss@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libffi-discuss mailing list <libffi-discuss.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libffi-discuss>,
 <mailto:libffi-discuss-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libffi-discuss/>
List-Post: <mailto:libffi-discuss@sourceware.org>
List-Help: <mailto:libffi-discuss-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libffi-discuss>,
 <mailto:libffi-discuss-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Feb 2021 16:09:49 -0000



On 2/5/21 1:38 PM, Madhavan T. Venkataraman wrote:
> 
> 
> On 2/5/21 12:46 PM, Anthony Green wrote:
>> On Fri, Feb 5, 2021 at 1:20 PM Madhavan T. Venkataraman <madvenka@linux.microsoft.com <mailto:madvenka@linux.microsoft.com>> wrote:
>>
>>     I have created the PR. Please review.
>>
>>
>> Thank you!
>>  
>>
>>     Do I also need to send the patchset to the libffi alias? Please advise.
>>
>>
>> No need.  
>>
>> I appreciate your efforts!
>>
>> AG
>>
> 
> The Appveyor CI tests are showing green. But the test logs still show a build
> failure somewhere. Let me fix that if I can. If you want to hold off on the review till
> then, that is fine.
> 
> Madhavan
> 

I have submitted static_tramp_v5. Here is the PR:

https://github.com/libffi/libffi/pull/624

All CI checks pass.

Please review.

Thanks!

Madhavan