From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22055 invoked by alias); 17 Sep 2009 21:09:10 -0000 Received: (qmail 22047 invoked by uid 22791); 17 Sep 2009 21:09:09 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail55.messagelabs.com (HELO mail55.messagelabs.com) (216.82.241.163) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Sep 2009 21:09:05 +0000 X-VirusChecked: Checked X-Env-Sender: rittle@latour.labs.mot.com X-Msg-Ref: server-12.tower-55.messagelabs.com!1253221742!94368362!1 X-StarScan-Version: 6.1.3; banners=-,-,- Received: (qmail 31413 invoked from network); 17 Sep 2009 21:09:03 -0000 Received: from motgate8.mot.com (HELO motgate8.mot.com) (129.188.136.8) by server-12.tower-55.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 17 Sep 2009 21:09:03 -0000 Received: from il06exr03.mot.com (il06exr03.mot.com [129.188.137.133]) by motgate8.mot.com (8.14.3/8.14.3) with ESMTP id n8HL92Ir016030 for ; Thu, 17 Sep 2009 14:09:02 -0700 (MST) Received: from il06vts02.mot.com (il06vts02.mot.com [129.188.137.142]) by il06exr03.mot.com (8.13.1/Vontu) with SMTP id n8HL92fj024698 for ; Thu, 17 Sep 2009 16:09:02 -0500 (CDT) Received: from latour.labs.mot.com (latour.labs.mot.com [10.2.201.16]) by il06exr03.mot.com (8.13.1/8.13.0) with ESMTP id n8HL92Xk024692 for ; Thu, 17 Sep 2009 16:09:02 -0500 (CDT) Received: from latour.labs.mot.com (localhost.labs.mot.com [127.0.0.1]) by latour.labs.mot.com (8.14.3/8.14.3) with ESMTP id n8HL7kvY020680; Thu, 17 Sep 2009 16:07:46 -0500 (CDT) (envelope-from rittle@latour.labs.mot.com) Received: (from rittle@localhost) by latour.labs.mot.com (8.14.3/8.14.3/Submit) id n8HL7kmS020677; Thu, 17 Sep 2009 16:07:46 -0500 (CDT) (envelope-from rittle) Date: Thu, 17 Sep 2009 21:09:00 -0000 From: Loren James Rittle Message-Id: <200909172107.n8HL7kmS020677@latour.labs.mot.com> To: libffi-discuss@sourceware.org Subject: PATCH: libffi for i386-*-freebsd* Reply-to: rittle@labs.mot.com Content-Type: text/plain; charset=US-ASCII X-CFilter-Loop: Reflected Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2009/txt/msg00247.txt.bz2 (Resent to upstream, now that I noticed that there is an upstream.) I wondered why saw this [in recent gcc 4.5 test results for i386-*-freebsd*]: FAIL: libffi.call/return_sc.c -O2 -O2 execution test FAIL: libffi.call/return_sc.c -O3 -O3 execution test FAIL: libffi.call/return_sc.c -Os -Os execution test FAIL: libffi.call/return_sc.c -O2 -fomit-frame-pointer -O2 -fomit-frame-pointer execution test on i386-unknown-freebsd7.2 with gcc mainline. Fixed with this (as commited to [gcc] mainline after testing against -r151782): 2009-09-17 Loren J. Rittle PR testsuite/32843 (strikes again) * src/x86/ffi.c (ffi_prep_cif_machdep): Add X86_FREEBSD to enable proper extension on char and short. Index: libffi/src/x86/ffi.c =================================================================== --- libffi/src/x86/ffi.c (revision 151782) +++ libffi/src/x86/ffi.c (working copy) @@ -155,7 +155,7 @@ #ifdef X86 case FFI_TYPE_STRUCT: #endif -#if defined(X86) || defined (X86_WIN32) || defined(X86_DARWIN) || defined(X86_WIN64) +#if defined(X86) || defined (X86_WIN32) || defined(X86_FREEBSD) || defined(X86_DARWIN) || defined(X86_WIN64) case FFI_TYPE_UINT8: case FFI_TYPE_UINT16: case FFI_TYPE_SINT8: