From: Alan Modra <amodra@gmail.com>
To: Andrew Haley <aph@redhat.com>
Cc: Bill Schmidt <wschmidt@linux.vnet.ibm.com>,
gcc-patches@gcc.gnu.org, libffi-discuss@sourceware.org,
dje@gcc.gnu.org
Subject: Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)
Date: Mon, 16 Sep 2013 23:38:00 -0000 [thread overview]
Message-ID: <20130916233848.GA28086@bubble.grove.modra.org> (raw)
In-Reply-To: <52317C41.8070303@redhat.com>
On Thu, Sep 12, 2013 at 09:33:05AM +0100, Andrew Haley wrote:
> On 09/12/2013 03:11 AM, Alan Modra wrote:
> > We have precedent for compiling libffi based on gcc preprocessor
> > defines, eg. __NO_FPRS__, so here's a way of making upstream libffi
> > compatible with the various versions of gcc out there. I've taken the
> > condition under which we align aggregates from
> > rs6000_function_arg_boundary, and defined a macro with a value of the
> > maximum alignment.
>
> I would have thought that a runtime or configure-time test in libffi
> would be better.
I don't see how a runtime check can be done, and a configure test just
adds another layer of indirection. How is testing a cpp macro at
configure time better than testing the same at compile time?
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2013-09-16 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1376494321.17852.17.camel@oc8801110288.ibm.com>
2013-09-11 11:38 ` Alan Modra
2013-09-11 11:55 ` Jakub Jelinek
2013-09-11 12:56 ` Bill Schmidt
2013-09-11 17:03 ` Jay
2013-09-12 2:11 ` Alan Modra
2013-09-12 8:33 ` Andrew Haley
2013-09-16 23:38 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916233848.GA28086@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=aph@redhat.com \
--cc=dje@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=libffi-discuss@sourceware.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).