From: Alan Modra <amodra@gmail.com>
To: Anthony Green <green@moxielogic.com>
Cc: libffi-discuss@sourceware.org
Subject: Re: Straying #endif in ppc_closure.S
Date: Tue, 19 Nov 2013 00:14:00 -0000 [thread overview]
Message-ID: <20131119001430.GX22514@bubble.grove.modra.org> (raw)
In-Reply-To: <87eh6e2b4o.fsf@redhat.com>
On Mon, Nov 18, 2013 at 06:38:15AM -0500, Anthony Green wrote:
> Alan Modra <amodra@gmail.com> writes:
>
> > An #endif in the wrong place would cause compile failure on powerpcle.
> > Using bl instead of b doesn't cause runtime failures as you might think,
> > but does mess the processor branch prediction.
>
> Thanks Alan. I've committed this along with all of your other recent
> changes. I'm also about to update the README to mention ELFv2 support.
Thanks! Someday I should pull powerpc/ffi.c apart into two files, one
for 32-bit and the other for 64-bit because you can't call 32-bit
functions from 64-bit code or vice versa. Having both lots of code
compiled in is just bloat, and there is really very little shared
code. Also, for the sin of adding #ifdef __STRUCT_PARM_ALIGN__ I
should go through all of the #if's in ffi.c and replace many with
tests on cif->abi, and define quite a few more abi values. Even
"#if FFI_TYPE_LONGDOUBLE != FFI_TYPE_DOUBLE" in ffi.c is wrong, or at
least incomplete in that libffi doesn't handle calls from
-mlong-double-64 code when libffi is compiled with -mlong-double-128.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2013-11-19 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 3:17 Alan Modra
2013-11-18 11:38 ` Anthony Green
2013-11-19 0:14 ` Alan Modra [this message]
2013-11-20 7:35 ` PowerPC64 ELFv2 fix 2 of 2 Alan Modra
2013-11-20 7:38 ` Tidy powerpc*-linux support Alan Modra
2014-05-30 5:10 ` Ryan Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119001430.GX22514@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).