From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29495 invoked by alias); 23 Jul 2014 08:41:23 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 29484 invoked by uid 89); 23 Jul 2014 08:41:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 23 Jul 2014 08:41:21 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 Jul 2014 09:41:18 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 Jul 2014 09:41:16 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 66D6C1B08069 for ; Wed, 23 Jul 2014 09:41:59 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6N8fFOT35192898 for ; Wed, 23 Jul 2014 08:41:15 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6N8fFPR022016 for ; Wed, 23 Jul 2014 04:41:15 -0400 Received: from bl3ahm9f.de.ibm.com (dyn-9-152-212-187.boeblingen.de.ibm.com [9.152.212.187]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s6N8fFCH022006 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 23 Jul 2014 04:41:15 -0400 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1X9s6s-00020v-Rs; Wed, 23 Jul 2014 10:41:14 +0200 Date: Wed, 23 Jul 2014 08:41:00 -0000 From: Dominik Vogt To: libffi-discuss@sourceware.org Subject: Re: [RFC][PATCH 1/3] Complex type support (FFI_TYPE_COMPLEX) Message-ID: <20140723084114.GA7290@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com References: <20140722092734.GA23937@linux.vnet.ibm.com> <20140722093534.GA30068@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140722093534.GA30068@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14072308-3548-0000-0000-000000A9D3D8 X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00075.txt.bz2 On Tue, Jul 22, 2014 at 10:35:34AM +0100, Dominik Vogt wrote: > FFI_ASSERT_VALID_TYPE(cif->rtype); > > /* x86, x86-64 and s390 stack space allocation is handled in prep_machdep. */ > -#if !defined M68K && !defined X86_ANY && !defined S390 && !defined PA > +#if !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION Just noticed that I forgot about M68K here. The correct condition is #if !defined M68K && !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION unless ... > FFI_ASSERT_VALID_TYPE(*ptr); > > -#if !defined X86_ANY && !defined S390 && !defined PA > +#if !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION ... this condition forgets to check M68K by accident or in case it does not matter. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany