From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6371 invoked by alias); 10 Nov 2014 09:51:16 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 6355 invoked by uid 89); 10 Nov 2014 09:51:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 10 Nov 2014 09:51:14 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Nov 2014 09:51:10 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 10 Nov 2014 09:51:08 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id D134E1B08023 for ; Mon, 10 Nov 2014 09:51:16 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAA9p8Op51249180 for ; Mon, 10 Nov 2014 09:51:08 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAA9p8fq003827 for ; Mon, 10 Nov 2014 02:51:08 -0700 Received: from bl3ahm9f.de.ibm.com (dyn-9-152-212-86.boeblingen.de.ibm.com [9.152.212.86]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sAA9p8mt003792 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 10 Nov 2014 02:51:08 -0700 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1Xnlcp-00019e-PK; Mon, 10 Nov 2014 10:51:07 +0100 Date: Mon, 10 Nov 2014 09:51:00 -0000 From: Dominik Vogt To: libffi-discuss@sourceware.org Subject: Re: Fix powerpc breakage from 6e8a4460 Message-ID: <20141110095107.GA3657@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com References: <20141110042442.GH3990@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141110042442.GH3990@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14111009-0013-0000-0000-000001CB303A X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00207.txt.bz2 On Mon, Nov 10, 2014 at 02:54:42PM +1030, Alan Modra wrote: > The addition of FFI_TYPE_COMPLEX broke powerpc libffi, showing up as > four testsuite failures on powerpc64le. This fixes the breakage and > ensures a more spectacular set of failures if something like this > happens again. > > * src/powerpc/ffitarget.h: #error on unexpected FFI_TYPE_LAST. ... > +/* ppc_closure.S and linux64_closure.S expect this. */ > +#define FFI_PPC_TYPE_LAST FFI_TYPE_POINTER > + > +/* We define additional types below. If generic types are added that > + must be supported by powerpc libffi then it is likely that > + FFI_PPC_TYPE_LAST needs increasing *and* the jump tables in > + ppc_closure.S and linux64_closure.S be extended. */ Does this affect only powerpc? Is there any risk of breaking other platforms too? Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany