From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25387 invoked by alias); 11 Nov 2014 13:19:57 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 25377 invoked by uid 89); 11 Nov 2014 13:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f175.google.com Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 11 Nov 2014 13:19:55 +0000 Received: by mail-pd0-f175.google.com with SMTP id y13so10125844pdi.34 for ; Tue, 11 Nov 2014 05:19:53 -0800 (PST) X-Received: by 10.66.97.39 with SMTP id dx7mr40184985pab.65.1415711993578; Tue, 11 Nov 2014 05:19:53 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-155-134.oycza5.sa.bigpond.net.au. [58.160.155.134]) by mx.google.com with ESMTPSA id g13sm19457356pat.45.2014.11.11.05.19.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2014 05:19:52 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 95599EA017C; Tue, 11 Nov 2014 23:49:45 +1030 (ACDT) Date: Tue, 11 Nov 2014 13:19:00 -0000 From: Alan Modra To: Dominik Vogt Cc: libffi-discuss@sourceware.org Subject: Re: Fix powerpc breakage from 6e8a4460 Message-ID: <20141111131945.GA18773@bubble.grove.modra.org> References: <20141110042442.GH3990@bubble.grove.modra.org> <20141110095107.GA3657@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141110095107.GA3657@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2014/txt/msg00210.txt.bz2 On Mon, Nov 10, 2014 at 10:51:07AM +0100, Dominik Vogt wrote: > On Mon, Nov 10, 2014 at 02:54:42PM +1030, Alan Modra wrote: > > The addition of FFI_TYPE_COMPLEX broke powerpc libffi, showing up as > > four testsuite failures on powerpc64le. This fixes the breakage and > > ensures a more spectacular set of failures if something like this > > happens again. > > > > * src/powerpc/ffitarget.h: #error on unexpected FFI_TYPE_LAST. > ... > > +/* ppc_closure.S and linux64_closure.S expect this. */ > > +#define FFI_PPC_TYPE_LAST FFI_TYPE_POINTER > > + > > +/* We define additional types below. If generic types are added that > > + must be supported by powerpc libffi then it is likely that > > + FFI_PPC_TYPE_LAST needs increasing *and* the jump tables in > > + ppc_closure.S and linux64_closure.S be extended. */ > > Does this affect only powerpc? Is there any risk of breaking other > platforms too? My patch only fixes powerpc. I hadn't looked at other targets, but a quick grep shows at least alpha-osf, ia64, and some x86 targets were broken by changing FFI_TYPE_LAST. -- Alan Modra Australia Development Lab, IBM