From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28975 invoked by alias); 21 Nov 2014 17:30:50 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 28960 invoked by uid 89); 21 Nov 2014 17:30:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 21 Nov 2014 17:30:46 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.1.203.34]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id sALHUaij021942; Fri, 21 Nov 2014 17:30:36 GMT Date: Fri, 21 Nov 2014 17:30:00 -0000 From: James Greenhalgh To: "libffi-discuss@sourceware.org" Cc: Marcus Shawcroft , "rth@redhat.com" , "green@moxielogic.com" Subject: Re: [Patch AArch64] Add missing .note.GNU-stack note Message-ID: <20141121173035.GA20263@arm.com> References: <1415892722-14244-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415892722-14244-1-git-send-email-james.greenhalgh@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00250.txt.bz2 *ping* Thanks, James On Thu, Nov 13, 2014 at 03:32:02PM +0000, James Greenhalgh wrote: > > Hi Anthony, > > This trivial patch fixes: > https://github.com/atgreen/libffi/issues/141 > > By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S. > > Tested native on aarch64-none-linux-gnu, with no issues in the testsuite. > > Could you please apply this to HEAD? > > Thanks, > James > > --- > > 2014-11-13 James Greenhalgh > > * aarch64/sysv.S: Add .note.GNU-stack. > > diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S > index 1fb68f2..d5b1c2e 100644 > --- a/src/aarch64/sysv.S > +++ b/src/aarch64/sysv.S > @@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV): > .size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV) > #endif > #endif /* FFI_GO_CLOSURES */ > + > +#if defined __ELF__ && defined __linux__ > + .section .note.GNU-stack,"",%progbits > +#endif