From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7468 invoked by alias); 22 Dec 2014 10:27:16 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 7458 invoked by uid 89); 22 Dec 2014 10:27:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp14.uk.ibm.com Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 22 Dec 2014 10:27:13 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Dec 2014 10:27:09 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 22 Dec 2014 10:27:07 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 95BDE17D8043 for ; Mon, 22 Dec 2014 10:27:34 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBMAR61u43385058 for ; Mon, 22 Dec 2014 10:27:07 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBMAR6du019068 for ; Mon, 22 Dec 2014 03:27:06 -0700 Received: from bl3ahm9f.de.ibm.com (sig-9-81-107-9.evts.de.ibm.com [9.81.107.9]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sBMAR50O018983 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 22 Dec 2014 03:27:06 -0700 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1Y30Ci-0003dN-0e; Mon, 22 Dec 2014 11:27:08 +0100 Date: Mon, 22 Dec 2014 10:27:00 -0000 From: Dominik Vogt To: libffi-discuss@sourceware.org Subject: Re: [PATCH] Go closures for s390[x] Message-ID: <20141222102707.GA9568@linux.vnet.ibm.com> Reply-To: libffi-discuss@sourceware.org Mail-Followup-To: libffi-discuss@sourceware.org References: <20141216150504.GA10835@linux.vnet.ibm.com> <5493471D.4020506@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5493471D.4020506@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14122210-0017-0000-0000-000002522E33 X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00279.txt.bz2 On Thu, Dec 18, 2014 at 03:29:01PM -0600, Richard Henderson wrote: > On 12/16/2014 09:05 AM, Dominik Vogt wrote: > > lm %r6,%r15,48+24(%r11) > > + .cfi_remember_state > > + .cfi_restore 15 > > + .cfi_restore 14 > > + .cfi_restore 13 > > + .cfi_restore 12 > > + .cfi_restore 11 > > + .cfi_restore 10 > > + .cfi_restore 9 > > + .cfi_restore 8 > > + .cfi_restore 7 > > + .cfi_restore 6 > > + .cfi_def_cfa r15, 96 > > br %r4 > > + .cfi_restore_state > > I'm not really sure you need any of these restores, since the data is still on > the stack, unclobbered. I think you'd really only need to reset the cfa here. I thought about that but left the cif-restores in the code for documentation purposes. Actually its probably better to remove them as they cost performance if they get executed. Sould I make a new patch, or is that something you wanted to post as part of your cleanup? Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany