From: Timothy Wall <twall@users.sf.net>
To: Dan Witte <dwitte@mozilla.com>
Cc: libffi-discuss <libffi-discuss@sourceware.org>,
Anthony Green <green@redhat.com>
Subject: Re: [PATCH] don't count return value space twice on x86
Date: Thu, 05 Aug 2010 01:43:00 -0000 [thread overview]
Message-ID: <485D93F4-737B-4F54-A3AE-767796EB6C31@users.sf.net> (raw)
In-Reply-To: <2028543733.185560.1280967209614.JavaMail.root@cm-mail03.mozilla.org>
I take it this is only under *some* circumstances, since I've used a number of different stdcall closures without issue.
On Aug 4, 2010, at 8:13 PM, Dan Witte wrote:
> Anthony,
>
> There's a bug in stdcall x86 WIN32 closure code where stack space for the return value is counted twice -- which leads to overpopping and a spectacular crash. This adds an X86_ANY define for all x86 plats, which simplifies logic and means that stack computation is done consistently in the x86 prep_cif_machdep, rather than double-counted by prep_cif.
>
> Look OK?
>
> Cheers,
> Dan.
> <libffi-patch-X86_ANY.diff>
next prev parent reply other threads:[~2010-08-05 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1772366822.185557.1280967205608.JavaMail.root@cm-mail03.mozilla.org>
2010-08-05 0:23 ` Dan Witte
2010-08-05 1:43 ` Timothy Wall [this message]
2010-08-05 2:51 ` Dan Witte
2010-08-05 3:42 ` Timothy Wall
2010-08-05 12:49 ` Anthony Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485D93F4-737B-4F54-A3AE-767796EB6C31@users.sf.net \
--to=twall@users.sf.net \
--cc=dwitte@mozilla.com \
--cc=green@redhat.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).