From: Rafael Avila de Espindola <respindola@mozilla.com>
To: libffi-discuss@sourceware.org
Subject: [patch] Check for libffi_cv_as_x86_pcrel should not look for just "warning"
Date: Fri, 04 Feb 2011 20:36:00 -0000 [thread overview]
Message-ID: <4D4C62FE.4070409@mozilla.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
The check that sets libffi_cv_as_x86_pcrel currently check for "warning"
or "illegal". The problem is that when trying to build libffi with LTO
clang will produce the warning
clang: warning: argument unused during compilation: '-emit-llvm'
The attached patch just uses the $CC error code instead. Is that OK or
is there some strange assembler out there that rejects the assembly bug
exists with 0?
Cheers,
Rafael
[-- Attachment #2: pcrel.patch --]
[-- Type: text/x-patch, Size: 1237 bytes --]
diff --git a/configure b/configure
index e086c65..a1c5ec8 100755
--- a/configure
+++ b/configure
@@ -14506,10 +14506,10 @@ if test "${libffi_cv_as_x86_pcrel+set}" = set; then
$as_echo_n "(cached) " >&6
else
- libffi_cv_as_x86_pcrel=yes
+ libffi_cv_as_x86_pcrel=no
echo '.text; foo: nop; .data; .long foo-.; .text' > conftest.s
- if $CC $CFLAGS -c conftest.s 2>&1 | $EGREP -i 'illegal|warning' > /dev/null; then
- libffi_cv_as_x86_pcrel=no
+ if $CC $CFLAGS -c conftest.s > /dev/null; then
+ libffi_cv_as_x86_pcrel=yes
fi
fi
diff --git a/configure.ac b/configure.ac
index c7cead8..c12c858 100644
--- a/configure.ac
+++ b/configure.ac
@@ -276,10 +276,10 @@ fi
if test x$TARGET = xX86 || test x$TARGET = xX86_WIN32 || test x$TARGET = xX86_64; then
AC_CACHE_CHECK([assembler supports pc related relocs],
libffi_cv_as_x86_pcrel, [
- libffi_cv_as_x86_pcrel=yes
+ libffi_cv_as_x86_pcrel=no
echo '.text; foo: nop; .data; .long foo-.; .text' > conftest.s
- if $CC $CFLAGS -c conftest.s 2>&1 | $EGREP -i 'illegal|warning' > /dev/null; then
- libffi_cv_as_x86_pcrel=no
+ if $CC $CFLAGS -c conftest.s > /dev/null; then
+ libffi_cv_as_x86_pcrel=yes
fi
])
if test "x$libffi_cv_as_x86_pcrel" = xyes; then
next reply other threads:[~2011-02-04 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 20:36 Rafael Avila de Espindola [this message]
2011-03-27 3:55 ` Rafael Ávila de Espíndola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4C62FE.4070409@mozilla.com \
--to=respindola@mozilla.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).