From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libffi-discuss-return-1143-listarch-libffi-discuss=sources.redhat.com@sourceware.org>
Received: (qmail 30766 invoked by alias); 23 Feb 2011 13:26:16 -0000
Received: (qmail 30758 invoked by uid 22791); 23 Feb 2011 13:26:15 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0	tests=BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f169.google.com (HELO mail-px0-f169.google.com) (209.85.212.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 13:26:09 +0000
Received: by pxi9 with SMTP id 9so626623pxi.0        for <libffi-discuss@sourceware.org>; Wed, 23 Feb 2011 05:26:08 -0800 (PST)
Received: by 10.142.194.10 with SMTP id r10mr2578131wff.376.1298467568209;        Wed, 23 Feb 2011 05:26:08 -0800 (PST)
Received: from [192.168.1.10] (59-104-108-116.adsl.dynamic.seed.net.tw [59.104.108.116])        by mx.google.com with ESMTPS id p40sm10773594wfc.17.2011.02.23.05.26.05        (version=SSLv3 cipher=OTHER);        Wed, 23 Feb 2011 05:26:07 -0800 (PST)
Message-ID: <4D650ADE.6040609@linaro.org>
Date: Wed, 23 Feb 2011 13:26:00 -0000
From: Chung-Lin Tang <cltang@linaro.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: David Gilbert <david.gilbert@linaro.org>
CC: Anthony Green <green@redhat.com>, libffi-discuss@sourceware.org,  Marcus.Shawcroft@arm.com
Subject: Re: [PATCH] Add variadic support
References: <20110222154022.GA29862@davesworkthinkpad>	<m3mxlm3owl.fsf@redhat.com> <AANLkTin-Ni=1bwQGYVN7nB9ZbQKXcs2XD=JTiaeft7j=@mail.gmail.com>
In-Reply-To: <AANLkTin-Ni=1bwQGYVN7nB9ZbQKXcs2XD=JTiaeft7j=@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libffi-discuss.sourceware.org>
List-Subscribe: <mailto:libffi-discuss-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libffi-discuss/>
List-Post: <mailto:libffi-discuss@sourceware.org>
List-Help: <mailto:libffi-discuss-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libffi-discuss-owner@sourceware.org
X-SW-Source: 2011/txt/msg00078.txt.bz2

On 2011/2/23 09:11 PM, David Gilbert wrote:
> In ARM's ffi_prep_cif_machdep I have:
> 
> +#ifdef __ARM_PCS_VFP
> +  /* VFP uses the standard ABI for variadic functions */
> +  if ((cif->abi == FFI_VFP) && (cif->nfixedargs != 0))
> +    cif->abi = FFI_SYSV;
> +#endif
> 
> and that's the only active change that's needed.

I suggest removing the #ifdef __ARM_PCS_VFP #ifdef.  We always have
support for both FFI_SYSV and FFI_VFP compiled in, so it doesn't make
sense to leave this bit of logic out when we are under __ARM_PCS.

Chung-Lin