From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25021 invoked by alias); 12 Sep 2013 08:33:18 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 24954 invoked by uid 89); 12 Sep 2013 08:33:17 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Sep 2013 08:33:17 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8C8XCci003076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Sep 2013 04:33:12 -0400 Received: from zebedee.pink (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8C8X5qd005493; Thu, 12 Sep 2013 04:33:06 -0400 Message-ID: <52317C41.8070303@redhat.com> Date: Thu, 12 Sep 2013 08:33:00 -0000 From: Andrew Haley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Bill Schmidt , gcc-patches@gcc.gnu.org, libffi-discuss@sourceware.org, dje@gcc.gnu.org Subject: Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue) References: <1376494321.17852.17.camel@oc8801110288.ibm.com> <20130911113845.GF2643@bubble.grove.modra.org> <1378904143.3730.46.camel@gnopaine> <20130912021149.GG2643@bubble.grove.modra.org> In-Reply-To: <20130912021149.GG2643@bubble.grove.modra.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013/txt/msg00163.txt.bz2 On 09/12/2013 03:11 AM, Alan Modra wrote: > We have precedent for compiling libffi based on gcc preprocessor > defines, eg. __NO_FPRS__, so here's a way of making upstream libffi > compatible with the various versions of gcc out there. I've taken the > condition under which we align aggregates from > rs6000_function_arg_boundary, and defined a macro with a value of the > maximum alignment. I would have thought that a runtime or configure-time test in libffi would be better. Andrew.