From: Samuli Suominen <ssuominen@gentoo.org>
To: libffi-discuss@sourceware.org
Subject: Re: [PATCH] Use $CFLAGS to calculate multi_os_directory in configure.ac.
Date: Mon, 03 Mar 2014 12:41:00 -0000 [thread overview]
Message-ID: <531477A9.5010007@gentoo.org> (raw)
In-Reply-To: <20140303123619.GA7627@linux.vnet.ibm.com>
On 03/03/14 14:36, Dominik Vogt wrote:
> configure.ac forgets to use $CFLAGS when running
>
> $CC -print-multi-os-directory
>
> This may result in a bad installation path for the library (on
> s390 I get ..../lib/../lib64 instead of just ..../lib" as it should
> be). The attached patch fixes that (configure needs to be
> regenerated.)
>
> Ciao
>
> Dominik ^_^ ^_^
>
Since we are on the /topic of -print-multi-os-directory and it's use in
libffi, I'd like to point out the concept is broken:
http://bugs.gentoo.org/show_bug.cgi?id=462814
It's in direct conflict with the use of --libdir= and is not flexible
enough to be used in packages like this.
What really should be done, is revert the patch that ever introduced the
use of -print-multi-os-directory for determining
the installation directory, or at the very least, force it to respect
--libdir=, not override --libdir=
- Samuli
next prev parent reply other threads:[~2014-03-03 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 12:36 Dominik Vogt
2014-03-03 12:41 ` Samuli Suominen [this message]
2014-03-03 12:43 ` Samuli Suominen
2014-03-03 12:56 ` Dominik Vogt
2014-03-03 13:05 ` Samuli Suominen
2014-03-03 13:34 ` Dominik Vogt
2014-03-03 13:44 ` Samuli Suominen
2014-03-03 14:10 ` Anthony Green
2014-03-12 6:49 ` [PING 1][PATCH] " Dominik Vogt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531477A9.5010007@gentoo.org \
--to=ssuominen@gentoo.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).