From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28399 invoked by alias); 3 Mar 2014 12:43:36 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 28366 invoked by uid 89); 3 Mar 2014 12:43:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 03 Mar 2014 12:43:33 +0000 Received: from [10.176.7.17] (85-76-107-46-nat.elisa-mobile.fi [85.76.107.46]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: ssuominen) by smtp.gentoo.org (Postfix) with ESMTPSA id 5A79033F7DC for ; Mon, 3 Mar 2014 12:43:31 +0000 (UTC) Message-ID: <5314783D.6090401@gentoo.org> Date: Mon, 03 Mar 2014 12:43:00 -0000 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: libffi-discuss@sourceware.org Subject: Re: [PATCH] Use $CFLAGS to calculate multi_os_directory in configure.ac. References: <20140303123619.GA7627@linux.vnet.ibm.com> <531477A9.5010007@gentoo.org> In-Reply-To: <531477A9.5010007@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00017.txt.bz2 On 03/03/14 14:38, Samuli Suominen wrote: > On 03/03/14 14:36, Dominik Vogt wrote: >> configure.ac forgets to use $CFLAGS when running >> >> $CC -print-multi-os-directory >> >> This may result in a bad installation path for the library (on >> s390 I get ..../lib/../lib64 instead of just ..../lib" as it should >> be). The attached patch fixes that (configure needs to be >> regenerated.) >> >> Ciao >> >> Dominik ^_^ ^_^ >> > Since we are on the /topic of -print-multi-os-directory and it's use in > libffi, I'd like to point out the concept is broken: > > http://bugs.gentoo.org/show_bug.cgi?id=462814 > > It's in direct conflict with the use of --libdir= and is not flexible > enough to be used in packages like this. > > What really should be done, is revert the patch that ever introduced the > use of -print-multi-os-directory for determining > the installation directory, or at the very least, force it to respect > --libdir=, not override --libdir= > > - Samuli So, we ended up using a hack like... sed -i 's:@toolexeclibdir@:$(libdir):g' Makefile.in ...to package libffi, but I don't agree forcing the use of `sed` is a good prereq for configuring a package to respect the users, systems, wishes