From: Samuli Suominen <ssuominen@gentoo.org>
To: libffi-discuss@sourceware.org
Subject: Re: libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order
Date: Wed, 04 Jun 2014 14:55:00 -0000 [thread overview]
Message-ID: <538F32BA.5030605@gentoo.org> (raw)
In-Reply-To: <87mwdy9kgr.fsf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On 31/05/14 15:55, Anthony Green wrote:
> Samuli Suominen <ssuominen@gentoo.org> writes:
>
>> I think 3.1.1 should be rolled to cover issues of:
> Thanks Samuli. I agree, and I've prepared almost everything. Could you
> please submit a patch for the last issue below?
>
> Thanks!
This patch seems to work here. Be careful, I tried my best to look
that it doesn't have any
unexpected consequences. As in, please test.
Thanks,
Samuli
>> 1. https://sourceware.org/ml/libffi-discuss/2014/msg00059.html
>> 2. https://sourceware.org/ml/libffi-discuss/2014/msg00058.html
>>
>> 3. This issue:
>>
>> $ ./configure --prefix=/usr
>> $ make
>> $ make install
>> $ pkg-config --libs libffi
>> -L$(libdir)/../lib64 -lffi
>>
>> Notice the (), it should be {}, so now every reverse dependency that tries
>> to link to libffi using info provided by --libs libffi, won't compile,
>> due to the
>> syntax error!
>>
>> - Samuli
[-- Attachment #2: configure.ac-libffi.pc.patch --]
[-- Type: text/x-patch, Size: 844 bytes --]
http://sourceware.org/ml/libffi-discuss/2014/msg00063.html
--- configure.ac
+++ configure.ac
@@ -590,11 +590,11 @@
if test "x$GCC" = "xyes"; then
if test -n "$with_cross_host" &&
test x"$with_cross_host" != x"no"; then
- toolexecdir='$(exec_prefix)/$(target_alias)'
- toolexeclibdir='$(toolexecdir)/lib'
+ toolexecdir="${exec_prefix}"/'$(target_alias)'
+ toolexeclibdir="${toolexecdir}"/lib
else
- toolexecdir='$(libdir)/gcc-lib/$(target_alias)'
- toolexeclibdir='$(libdir)'
+ toolexecdir="${libdir}"/gcc-lib/'$(target_alias)'
+ toolexeclibdir="${libdir}"
fi
multi_os_directory=`$CC $CFLAGS -print-multi-os-directory`
case $multi_os_directory in
@@ -603,7 +603,7 @@
esac
AC_SUBST(toolexecdir)
else
- toolexeclibdir='$(libdir)'
+ toolexeclibdir="${libdir}"
fi
AC_SUBST(toolexeclibdir)
next prev parent reply other threads:[~2014-06-04 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 10:58 Samuli Suominen
2014-05-31 12:55 ` Anthony Green
2014-06-04 14:55 ` Samuli Suominen [this message]
2014-06-12 10:57 ` Anthony Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F32BA.5030605@gentoo.org \
--to=ssuominen@gentoo.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).