From: Alan Lawrence <alan.lawrence@arm.com>
To: libffi-discuss@sourceware.org
Subject: [PATCH] Fix compile failure on AArch64 Linux builds
Date: Tue, 23 Sep 2014 12:36:00 -0000 [thread overview]
Message-ID: <5421694F.80209@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Hi,
commit 5df384077f3633ec8cf2e08f9199e5a44994dbad (Merge pull request #129 from
frida/fix/darwin-aarch64-cif-prep // Fix non-variadic CIF initialization for
Apple/ARM64) breaks building libffi on aarch64 linux (e.g.
aarch64-none-linux-gnu), with error:
../src/aarch64/ffi.c: In function 'ffi_prep_cif_machdep':
../src/aarch64/ffi.c:785:6: error: 'ffi_cif' has no member named
'aarch64_nfixedargs'
cif->aarch64_nfixedargs = 0;
^
make[3]: *** [src/aarch64/ffi.lo] Error 1
Attached patch is a simple fix, tested on aarch64-none-linux-gnu. Is this OK for
trunk (and if so, can someone with write access please commit)?
Thanks, Alan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libffi_aarch64_nfixedargs.patch --]
[-- Type: text/x-patch; name=libffi_aarch64_nfixedargs.patch, Size: 307 bytes --]
diff --git a/src/aarch64/ffi.c b/src/aarch64/ffi.c
index 5369ea4..cdb7816 100644
--- a/src/aarch64/ffi.c
+++ b/src/aarch64/ffi.c
@@ -782,7 +782,9 @@ ffi_prep_cif_machdep (ffi_cif *cif)
}
}
+#if defined (__APPLE__)
cif->aarch64_nfixedargs = 0;
+#endif
return FFI_OK;
}
reply other threads:[~2014-09-23 12:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421694F.80209@arm.com \
--to=alan.lawrence@arm.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).