From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24980 invoked by alias); 15 Dec 2014 20:11:00 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 24833 invoked by uid 89); 15 Dec 2014 20:10:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Dec 2014 20:10:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBFKAr0l022559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 15 Dec 2014 15:10:53 -0500 Received: from pike.twiddle.home (vpn-61-25.rdu2.redhat.com [10.10.61.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBFKAqmF030569; Mon, 15 Dec 2014 15:10:52 -0500 Message-ID: <548F4046.7000602@redhat.com> Date: Mon, 15 Dec 2014 20:11:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: libffi-discuss@sourceware.org, gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: [gofrontend-dev] Re: [PATCH 00/13] Go closures, libffi, and the static chain References: <1412973773-3942-1-git-send-email-rth@redhat.com> <20141211090623.GA30484@linux.vnet.ibm.com> <20141211092144.GE4283@bubble.grove.modra.org> <20141211103106.GA9789@linux.vnet.ibm.com> <20141211122519.GA26215@linux.vnet.ibm.com> <5489F6D0.8020009@redhat.com> <20141212120630.GA32026@linux.vnet.ibm.com> <548B307D.60000@redhat.com> <20141215094223.GA3890@linux.vnet.ibm.com> In-Reply-To: <20141215094223.GA3890@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00262.txt.bz2 On 12/15/2014 03:42 AM, Dominik Vogt wrote: > On Fri, Dec 12, 2014 at 10:14:21AM -0800, Richard Henderson wrote: >> On 12/12/2014 04:06 AM, Dominik Vogt wrote: >>> I'm not sure I've posted the missing patch anywhere yet, so it's >>> attached to this message. At the moment it enables >>> FFI_TYPE_COMPLEX only for s390[x], but eventually this should be >>> used unconditionally. >> >> Thanks for that. I'd been meaning to get around to that. I'll change the test >> to use FFI_TARGET_HAS_COMPLEX_TYPE and apply it to my branch. > > Good. I'm not sure whether it's a good idea to expose > FFI_TARGET_HAS_COMPLEX_TYPE as part of the libffi interface > though. It was meant as a temporary thing to be removed once all > platforms supported by libffi have implemented complex support. A > while ago I've posted a patch to change the macro's name to begin > with an underscore to make that clearer. It's our copy of libffi -- I think we can assume any internals we like. Similarly, when I finish writing the bits that allow libffi to handle empty structures, I don't plan to conditionalize libgo, I simply plan to assume it works. r~